GithubHelp home page GithubHelp logo

Comments (4)

everton-rosario avatar everton-rosario commented on April 19, 2024 1

@ronaldgj Thanks for flagging this.
So far we are not aiming to move to the newest version of CSS selector because it requires PHP > 5.5.+ and we still need to have it compatible to PHP >= 5.4.

What I recommend you to do is:

  • Checkout the master version of this component

  • Change composer.json to set required version of the CSS Selector:

    "require": {
          "php": "^5.4 || ^7.0",
          "symfony/css-selector": "3.*",
          "facebook/graph-sdk": "~5.0",
          "apache/log4php": "2.3.0"
      }
    
  • Run composer update then composer install

It will build a version compatible as you need.

Thanks for flagging this and let me know if that procedure works for you.

from facebook-instant-articles-sdk-php.

ronaldgj avatar ronaldgj commented on April 19, 2024 1

For now I changed the composer.json of Laravel back to 2.8. I saw Laravel only uses it for 'tests'. For now I'm not using that so this is a temporary solution for me. I'll will try this soon and let you know if it worked!

Thank you for your respons!

from facebook-instant-articles-sdk-php.

kamranata avatar kamranata commented on April 19, 2024 1

Hi @everton-rosario. I saw you added to your composer.json
"php": "^5.4 || ^5.6 || ^7", "symfony/css-selector": "^2.8 || ^3.1 || ^4.1",

But when I use composer require facebook/facebook-instant-articles-sdk-php composer uses another json file. "php": "^5.4 || ^7.0", "symfony/css-selector": "^2.8 || ^3.0",

Can you fix this?

from facebook-instant-articles-sdk-php.

everton-rosario avatar everton-rosario commented on April 19, 2024

So you're mentioning a conflict with the symfony/css-selector. Can you propose a PR so I can understand better what you are proposing?

Thanks for reporting it.

from facebook-instant-articles-sdk-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.