GithubHelp home page GithubHelp logo

Comments (1)

5anniversary avatar 5anniversary commented on April 28, 2024

Hello I've same issue, encountered a crash issue related to infinite recursion in the view hierarchy manipulation when attempting to modify the layer hierarchy to prevent screenshots. This occurs specifically during the traversal by +[FBSDKViewHierarchy recursiveGetLabelsFromView:] method in the Facebook iOS SDK.

The manipulation involves making a UITextField secure and non-interactive, and then adjusting its layer within the hierarchy. This process seems to trigger an infinite loop in the hierarchy search, leading to a crash.

Here's the code snippet that leads to this issue:

let textField = UITextField()
textField.isSecureTextEntry = true
textField.isUserInteractionEnabled = false
self.addSubview(textField)
textField.centerYAnchor.constraint(equalTo: self.centerYAnchor).isActive = true
textField.centerXAnchor.constraint(equalTo: self.centerXAnchor).isActive = true

textField.layer.removeFromSuperlayer()
self.layer.superlayer?.insertSublayer(textField.layer, at: 0)
textField.layer.sublayers?.last?.addSublayer(self.layer)

After the textField is configured and its layer is rearranged in the hierarchy, the SDK's method for traversing the view hierarchy seems to enter an infinite recursion, causing a crash.

To address this, I propose introducing a limit to the depth of recursion in the +[FBSDKViewHierarchy recursiveGetLabelsFromView:] method. Implementing a recursion depth limit could prevent such crashes by avoiding infinite loops in scenarios where complex layer manipulations lead to cyclic dependencies in the view hierarchy.

This suggestion aims to enhance the stability of the SDK when handling complex view and layer hierarchies, preventing crashes and improving overall usability.

from facebook-ios-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.