URL tags creating error (V2.6) about facebook-java-business-sdk

[JiamingFB]

I just applied a patch for it in latest code. Looks like the encoding bug has been there for a while, but seemingly it didn't break the request (server has some level of tolerance) unless the body contains special characters like "&"

If you want to stay in v2.6, you can copy that one-line change :)

[JiamingFB]

Hi sang-d,

It might be related to json escaping of special characters. Would you mind posting some code snippet of your code?

Also, you can pass an AdCreative object as param instead of a json string, which would better handle the encoding.

Thanks!

[sang-d]

hi JiamingFB,
Thanks for quick response. Following is code section to create the ad:

AdCreative creative = new AdCreative(); creative.setFieldTitle(obj.getString("title")); creative.setFieldBody(obj.getString("body")); creative.setFieldLinkUrl(obj.getString("link_url")); creative.setFieldObjectUrl(obj.getString("object_url")); creative.setFieldImageHash(obj.getString("image_hash")); if (obj.has("url_tags")) { creative.setFieldUrlTags(obj.getString("url_tags")); }

BatchRequest batch = new BatchRequest(context); APIRequestCreateAd req = account.createAd().setAdsetId(adsetId).setCreative(creative).setName(variantName) .setStatus(Ad.EnumStatus.VALUE_PAUSED); req.addToBatch(batch);

Thanks,
Sang

[sang-d]

hi JiamingFB,

This issue happens only when creating ad in a BATCH request.
I just tried with single request execute, then it works fine.

For eg above, if I set:
creative.setFieldUrlTags("k=1&x=2&y=3");
It will throw error. Or it also happens if i put:
creative.setFieldLinkUrl("http://sdinh.net?k=1&x=2&y=3");

Please take a look.
Thanks
Sang

[JiamingFB]

Hi sang-d,

Looks like there is a bug in encoding when assembling batch request. The "body" in batch request is supposed to be url-encoded, but it's not encoded right now.

Sorry for the inconvenience. I'll work on the fix.