GithubHelp home page GithubHelp logo

Comments (7)

paulbain avatar paulbain commented on April 16, 2024

We have considered it but as you highlighted, the problem is having to use a real ad account and app.
It's something we definitely want to do so we'll work something out.

from facebook-php-business-sdk.

paulbain avatar paulbain commented on April 16, 2024

@pruno, any thoughts here?

from facebook-php-business-sdk.

pruno avatar pruno commented on April 16, 2024

Hi @bjeavons,

1 - unfortunately is not feasible for security reasons
2 - the majority of tests are integration tests, this is a design choice made to grant an always up to date SDK. I feel that considering the number of unit tests, running them as part of CI won't have relevance in ensuring the stability of the SDK

from facebook-php-business-sdk.

bjeavons avatar bjeavons commented on April 16, 2024

I hear you that it technically doesn't make a lot of sense or provides a lot of value at the moment. However, from my perspective, having transparency into the testing process and results gives me (and others) better assurance and greater confidence in the code and dev changes. For example, several phpunit tests for 2.2.0 are failing for me (I've got to investigate further because in some cases running a test individually shows it passing). But, if I could see a travis-ci badge that says master or tag 2.2.0 are "OK" then I feel better about updating my app and testing it out.

from facebook-php-business-sdk.

brucehazan avatar brucehazan commented on April 16, 2024

Thanks @bjeavons - you have a valid point, I have asked the team to look into a solution for running tests continuously for the reasons you mention. It might not be with Travis but we'll figure something out. Thanks for your support.

from facebook-php-business-sdk.

bjeavons avatar bjeavons commented on April 16, 2024

Nice! 9a023d9

from facebook-php-business-sdk.

pruno avatar pruno commented on April 16, 2024

;)

from facebook-php-business-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.