Comments (4)
Would you submit a PR?
from fb303.
So this is intentional - since fb303's API is not stable, leaving the SONAME unset means CMake uses the same value for version and soname. Packagers building shared libraries should make sure to always bump the version.
I'm open to better ideas, or maybe we should just document this better.
from fb303.
You don't set SONAME at all. You should add the corresponding argument to the link command.
from fb303.
see https://cmake.org/cmake/help/latest/prop_tgt/VERSION.html
For shared libraries VERSION and SOVERSION can be used to specify the build version and API version respectively. When building or installing appropriate symlinks are created if the platform supports symlinks and the linker supports so-names. If only one of both is specified the missing is assumed to have the same version number.
Oh, wait, you mean SONAME, not SOVERSION. Where would you suggest it should be set? libfb303_thrift_cpp is eventually generated by this (add_fbthrift_library
invokes add_fbthrift_cpp_library
)
fb303/build/fbcode_builder/CMake/FBThriftCppLibrary.cmake
Lines 129 to 139 in 9cf1b57
from fb303.
Related Issues (8)
- Enable automatic tagging HOT 1
- Tag releases? HOT 2
- Cmake build failing HOT 4
- Undefined symbols: "__ZTHN6apache6thrift15ServerInterface14requestParams_E" HOT 1
- Doesn't configure when fbthrift isn't built with python HOT 3
- Installs an empty directory include/fb303/test HOT 1
- building fails with folly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fb303.