Comments (6)
Is the fbjs in there 0.8.0-alpha.2 or 0.8.0? Not much should have changed between.
from fbjs.
It's the alpha.2, I renamed the issue.
It's the version used by draft-js https://github.com/facebook/draft-js/blob/master/package.json#L32 and [email protected] https://github.com/facebook/react/blob/master/package.json#L38
I don't have the same issue by upgrading react and react-dom to this version on my project (and without draft-js). Maybe it's because react(-dom) don't use fbjs/lib/UserAgent
?
from fbjs.
Hum, I also tried with [email protected] and still have the same issue using draft-js
from fbjs.
Ah, I think this is a polyfill related issue. query.startsWith(name)
is expecting String.prototype.startsWith
to exist. This is a new method in ES6 (MDN). Especially in Phantom, even new Phantom, you're going to need to include a polyfill for some of these things. The same holds true in real browser environments.
See the note in the docs: https://facebook.github.io/draft-js/docs/advanced-topics-issues-and-pitfalls.html#polyfills In the future we might compile that away and ship with a polyfill (or inline method) ourselves but for the time being, we're going to just depend on the method existing.
Let me know if that doesn't work and we can reopen and reinvestigate.
from fbjs.
PS, thanks for the awesomely detailed report including a repro and (what you could get of a) stack trace.
from fbjs.
Oh, ok I understand !
I fix the issue by adding babel-polyfill
to the karma.conf.js
file.
Thank you for your help and yours quicks answers !
from fbjs.
Related Issues (20)
- Low vulnerability
- ua-parser-js high severity vulnerability HOT 1
- Add CI check to ensure lockfiles up to date
- [security] upgrade to latest version of isomorphic-fetch HOT 10
- CVE-2017-16086 found in ua-parser.js HOT 2
- ua-parser-js to fix Regular Expression Denial Of Service (ReDoS) HOT 1
- areEqual doesn't support objects with null prototypes
- Got error "Cannot destructure property 'instrument' of 'options' as it is undefined" when using with jest:27.0.4 HOT 2
- missing v3.0.0 relase and tag HOT 1
- ua-parser-js Dependency Security vulnerability HOT 1
- 'instrument' required, then optional? Resulting in `TypeError: Cannot destructure property 'instrument' of 'options' as it is undefined.`
- fbjs > [email protected]: this package has been hijacked HOT 1
- [security-update] Update ua-parser-js dependency in fbjs HOT 1
- "ua-parser-js": "0.7.30" have a wrong HOT 3
- Security vulnerability with cross-fetch in fbjs HOT 3
- ChainAlert: new npm maintainer has published version 3.0.3 of package fbjs HOT 3
- Git.io deprecation notice
- upgrade core-js version HOT 1
- ua-parser-js ReDoS Vulnerability HOT 1
- nullthrows has either bad condition or bad error message HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fbjs.