Comments (4)
We are using the inline-require
transform for unit tests to do lazy mocking and to be able to use top-level requires in jest unit tests to be more consistent with how we write regular modules. We shouldn't be applying it to third-party code that doesn't need transforms to be applied, I'll fix the issue in react-native.
The issue is:
var A = require('A');
A = Foo;
gets transformed to
require('A') = Foo;
from fbjs.
Makes sense! That would be super weird. Thanks for the explanation.
from fbjs.
@cpojer I've found another case where this transform is being applied to vendored code. Trying to run xcode integration tests in react-native 0.12 or 0.13, on circle ci results in the following from the packager:
{"message":"TransformError: /Users/distiller/shopify-native/node_modules/react-native/node_modules/react-tools/src/shared/vendor/performance/performanceNow.js: /Users/distiller/shopify-native/node_modules/react-native/node_modules/react-tools/src/shared/vendor/performance/performanceNow.js: Cannot assign to a require(...) alias, performance. Line: 21","type":"TransformError","errors":[{}]}
from fbjs.
I don't know how the xcode integration tests are being run but they need to manually ignore performanceNow for now, just like the jest preprocessor in react-native does. @balpert will be upgrading react-native to react 0.14 soon, so this issue will go away. Also cc @ide in case he knows anything about circleci setup.
from fbjs.
Related Issues (20)
- CVE-2017-16086 found in ua-parser.js HOT 2
- ua-parser-js to fix Regular Expression Denial Of Service (ReDoS) HOT 1
- areEqual doesn't support objects with null prototypes
- Got error "Cannot destructure property 'instrument' of 'options' as it is undefined" when using with jest:27.0.4 HOT 2
- missing v3.0.0 relase and tag HOT 1
- ua-parser-js Dependency Security vulnerability HOT 1
- 'instrument' required, then optional? Resulting in `TypeError: Cannot destructure property 'instrument' of 'options' as it is undefined.`
- fbjs > [email protected]: this package has been hijacked HOT 1
- [security-update] Update ua-parser-js dependency in fbjs HOT 1
- "ua-parser-js": "0.7.30" have a wrong HOT 3
- Security vulnerability with cross-fetch in fbjs HOT 3
- ChainAlert: new npm maintainer has published version 3.0.3 of package fbjs HOT 3
- Git.io deprecation notice
- upgrade core-js version HOT 1
- ua-parser-js ReDoS Vulnerability HOT 1
- nullthrows has either bad condition or bad error message HOT 1
- Analysis: 100% of dependency updates in this repository can be merged.
- Deprecated babel plugins HOT 1
- ua-parser-js changing to AGPL license in v2.x
- Consider removing `cross-fetch` dependency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fbjs.