array has incomplete element type 'struct rcd_rebinding' about fbretaincycledetector

[kastiglione]

Thanks for the report, and the follow up.

I think FBRetainCycleDetector should either:

1. Add rcd_ prefix to fishhook.h
2. Remove rcd_ prefixes from functions in fishhook.h

Option 2 should be possible following facebook/fishhook#29

[crespoxiao]

to the guys who searched this issue,
it's not a common problem.the reason of this error is my workspace has 2 fishhook class files, one belongs to FBRetainCycleDetector lib and another belongs to a private lib. just keep one and it would be ok.

[k0nserv]

I'm also seeing this with React Native 0.49.0 which introduced a fishhook in facebook/react-native@878b7e4. This causes a conflict because the project also depends on FBMemoryProfiler which in turn has a dependncy on FBRetainCycleDetector where another fishhhook exists.

Is the only solution for this issue to remove one of the two?

[kastiglione]

@k0nserv do you mind pasting the compilation error?

It should be achievable to have both use fishhook independently without conflict.

[k0nserv]

It's the same as above regarding rcd_rebinding. I got lucky and we had stopped using FBMemoryProfiler so I could just remove it leaving us only with the FBRetainCycleDetector from React Native