GithubHelp home page GithubHelp logo

Comments (14)

yangshun avatar yangshun commented on April 26, 2024 1

Btw @sshhdaniella is saying that he will be helping to do the migration. On our end we just need to review.

from fbt.

yangshun avatar yangshun commented on April 26, 2024 1

Option 2. @sshhdaniella will do the migration, we (Docusaurus side + FBT) will review together

from fbt.

yangshun avatar yangshun commented on April 26, 2024 1

Hey @jrwats, for those Docusaurus 1 security vulnerabilities, I've fixed them upstream and upgrading your Docusaurus version would get rid of them. You could do that first in the meanwhile.

from fbt.

yangshun avatar yangshun commented on April 26, 2024

Ref: facebook/docusaurus#1834

from fbt.

jrwats avatar jrwats commented on April 26, 2024

Embeddable interactive React components within markdown via MDX

Yes! I've been wanting to add our demo app to the docs! https://i.giphy.com/3o6ZteX8cqJRH4TwQ0.gif

cc @w1106c @kayhadrin

from fbt.

jrwats avatar jrwats commented on April 26, 2024

Sorry are we

  1. Supposed to do this migration and have you/Daniella review, or
  2. is @sshhdaniella doing this migration with your review?

Either way it'll be nice to have embedded React

from fbt.

jrwats avatar jrwats commented on April 26, 2024

Awesome

from fbt.

jrwats avatar jrwats commented on April 26, 2024

@sshhdaniella, what does your timeline look like for this? I ask because we have 2 vulnerabilities from the packages remarkable <= 1.7.1 and underscore.string < 3.3.5 that are only brought in due to Docusaurus v1.

from fbt.

jrwats avatar jrwats commented on April 26, 2024

It looks like docusaurus v1.14.0 still depends on [email protected].

Does this actually fix the security vulnerability? The issue I have says there's "No fix version known"

Package name: remarkable
Affected versions: <= 1.7.1
Fixed in version: (No fix version known)
CVE: CVE-2019-12043
Reference: https://nvd.nist.gov/vuln/detail/CVE-2019-12043

from fbt.

jrwats avatar jrwats commented on April 26, 2024

@yangshun remarkable 1.7.4 is still bringing in underscore.string too

from fbt.

yangshun avatar yangshun commented on April 26, 2024

@sshhdaniella I'm freeing up this issue for others to take up since we have not gotten a response from you. Let us know if you're still interested.

from fbt.

yangshun avatar yangshun commented on April 26, 2024

@jrwats apologies for the mistake, it's weird that only fbt is seeing the vulnerability. I'll try to get someone to migrate fbt or even do it myself so that the vulnerability goes away.

For the most part, most security vulnerabilities are low-signal and since docusaurus produces statically generated sites, the severity is smaller.

from fbt.

endiliey avatar endiliey commented on April 26, 2024

try running yarn upgrade to recreate lockfile. also make sure to update to latest version of docusaurus

from fbt.

dtaylorbrown avatar dtaylorbrown commented on April 26, 2024

@yangshun Hi, apologies for the delay. I've recently gotten married and have since been away and taken some time off. Yes, please feel free to re-assign, I most likely won't get the time in the coming weeks to work on this.

from fbt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.