Thread 1: EXC_BAD_ACCESS about fishhook

[swolchok]

Have you updated your local checkout of fishhook recently? It's difficult to tell without the full crash report, but 4eeb18c fixed an issue that fits the description you provided.

[meiszhe]

Have you updated your local checkout of fishhook recently? It's difficult to tell without the full crash report, but 4eeb18c fixed an issue that fits the description you provided.

Hello, i updated my local checkout, but the crash occured again.
if (cur->rebindings[j].replaced != NULL && indirect_symbol_bindings[i] != cur->rebindings[j].replacement) { *(cur->rebindings[j].replaced) = indirect_symbol_bindings[i]; }
Crash Info : Thread 1: EXC_BAD_ACCESS (code=2, address=0x106ea8c90)
I use fishhook (I add 'cwsa' prefix ):
const struct mach_header *header = _dyld_get_image_header(index); intptr_t slide = _dyld_get_image_vmaddr_slide(index); cwsa_rebind_symbols_image(header, slide, (struct cwsa_rebinding[1]){ {"objc_msgSend", cwsa_hook_objc_msgSend, (void *)&cwsa_hook_objc_msgSend} }, 1);
If you know the reason, please tell me, thank you.

[meiszhe]

Have you updated your local checkout of fishhook recently? It's difficult to tell without the full crash report, but 4eeb18c fixed an issue that fits the description you provided.

I think i find the reason, {"objc_msgSend", cwsa_hook_objc_msgSend, (void *)&cwsa_hook_objc_msgSend}should be {"objc_msgSend", cwsa_hook_objc_msgSend, (void *)&cwsa_orig_objc_msgSend}.
I changed this, and the crash disappeared.

[swolchok]

Glad you were able to get it fixed!

[Joan0018]

Have you updated your local checkout of fishhook recently? It's difficult to tell without the full crash report, but 4eeb18c fixed an issue that fits the description you provided.

Hello, i updated my local checkout, but the crash occured again. if (cur->rebindings[j].replaced != NULL && indirect_symbol_bindings[i] != cur->rebindings[j].replacement) { *(cur->rebindings[j].replaced) = indirect_symbol_bindings[i]; } Crash Info : Thread 1: EXC_BAD_ACCESS (code=2, address=0x106ea8c90) I use fishhook (I add 'cwsa' prefix ): const struct mach_header *header = _dyld_get_image_header(index); intptr_t slide = _dyld_get_image_vmaddr_slide(index); cwsa_rebind_symbols_image(header, slide, (struct cwsa_rebinding[1]){ {"objc_msgSend", cwsa_hook_objc_msgSend, (void *)&cwsa_hook_objc_msgSend} }, 1); If you know the reason, please tell me, thank you.

May I know, where did I add this? currently facing the same issue

XCode version: 13.2.1
MacOS version: 12.1
RN version 0.59