GithubHelp home page GithubHelp logo

Comments (7)

tcoopman avatar tcoopman commented on July 27, 2024

As a possible workaround at the moment you could parse write your own script that parses flow --json and checks for passed.

from flow.

dsereni avatar dsereni commented on July 27, 2024

This is a bug, flow returns a nonzero code on error if the (flow start; flow) workflow is used but not if 'flow check' is used. flow check is better for CI though. Will fix. tcoopman's workaround should work in the meantime

from flow.

joshkalpin avatar joshkalpin commented on July 27, 2024

@dsereni if this is a simple case of setting the right status code somewhere I could attempt to fix it myself. I just have very little knowledge of OCaml (although, I feel like I could figure it out if it's small) and just am not sure where to even look.

from flow.

dsereni avatar dsereni commented on July 27, 2024

@kapin actually I just fixed it today - it just won't get pushed to GitHub until tomorrow (release day == busy day :-D). If you're interested in fixing a similar problem to learn the codebase let me know; it was reported on the IRC channel that we don't autostart the flow server on 'flow autocomplete' (used by IDEs) and that's definitely on the shortlist of stuff to fix.

In any case the wrong status code issue will be fixed in GitHub by tomorrow. Thanks for reporting!

from flow.

joshkalpin avatar joshkalpin commented on July 27, 2024

If I get some free time I'd be interested. Could you also let me know when the binaries are updated?

from flow.

dsereni avatar dsereni commented on July 27, 2024

Actually I'm about to do a deploy later tonight, I'll update this issue when it's pushed. I ended up including the auto start thing too, but I'm sure there'll be loads more like it coming down the pipeline :-)

from flow.

dsereni avatar dsereni commented on July 27, 2024

0.1.1 is out with the fix, including the new binaries.

from flow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.