Comments (7)
As a possible workaround at the moment you could parse write your own script that parses flow --json
and checks for passed.
from flow.
This is a bug, flow returns a nonzero code on error if the (flow start; flow) workflow is used but not if 'flow check' is used. flow check is better for CI though. Will fix. tcoopman's workaround should work in the meantime
from flow.
@dsereni if this is a simple case of setting the right status code somewhere I could attempt to fix it myself. I just have very little knowledge of OCaml (although, I feel like I could figure it out if it's small) and just am not sure where to even look.
from flow.
@kapin actually I just fixed it today - it just won't get pushed to GitHub until tomorrow (release day == busy day :-D). If you're interested in fixing a similar problem to learn the codebase let me know; it was reported on the IRC channel that we don't autostart the flow server on 'flow autocomplete' (used by IDEs) and that's definitely on the shortlist of stuff to fix.
In any case the wrong status code issue will be fixed in GitHub by tomorrow. Thanks for reporting!
from flow.
If I get some free time I'd be interested. Could you also let me know when the binaries are updated?
from flow.
Actually I'm about to do a deploy later tonight, I'll update this issue when it's pushed. I ended up including the auto start thing too, but I'm sure there'll be loads more like it coming down the pipeline :-)
from flow.
0.1.1 is out with the fix, including the new binaries.
from flow.
Related Issues (20)
- [flow-remove-types] doesn't remove some types HOT 1
- flow_parser.js file increased from 0.7M to 2.7M in v0.210 HOT 4
- `Omit` does not work well with unions HOT 3
- ☂️ Known unsoundness issues
- Partial type does not accept plain empty object literal as a default HOT 5
- Cannot return class type as T: Cannot return `root(...)` because a call signature declaring the expected parameter / return type is missing in `SomeModel` [1] but exists in function type [2].Flow(prop-missing) HOT 2
- Does not narrow down type after undefined/falsy check HOT 1
- Recursive/deep Partial HOT 2
- Bugs in negated `instanceof` expressions HOT 1
- [Question]: How to fix flowgen test after flow update HOT 3
- [Discussion]: Any plans to make Flow more interpopble with TS ecosystem? HOT 5
- Higher order type parameter support HOT 1
- Readme links to 404
- Strange index signature error if you use $Keys<O> instead of the equivalent literal union inside $ReadOnlyArray HOT 1
- [homebrew] automation script needs update HOT 2
- "Unxepcted identifier, expected the token ;" when using await inside of ES module HOT 3
- Can't iterate through chars in a string HOT 4
- Flow does not catch invalid switch statements HOT 1
- Conditional type only works if I inline it HOT 5
- Object with null prototype does not extend interface {} HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flow.