GithubHelp home page GithubHelp logo

Comments (5)

SamChou19815 avatar SamChou19815 commented on April 28, 2024

This is expected behavior. The difference is caused by whether the generic react component has some typing context coming from the parent. If there is a usable typing context, then even if some type argument cannot be solved from arguments and return hints, we will happily use default of the type parameter or bound (mixed if not specified) of the type parameter as the solution.

from flow.

ansonlouis avatar ansonlouis commented on April 28, 2024

So the react element tree changes typing context?

function Component<T: number>(pprops: {a:T}): Node {}

// pass (good)
<Component a={1} />;

// fail (good)
<Component a="str" />;

// pass?
(
    <div>
        <Component a={true} />
    </div>
)

TryFlow

from flow.

SamChou19815 avatar SamChou19815 commented on April 28, 2024

The new example seems like a bug. I will reopen and investigate.

from flow.

ansonlouis avatar ansonlouis commented on April 28, 2024

Thanks. Sorry, it took me a second to realize the issue could be boiled down more simply

from flow.

ansonlouis avatar ansonlouis commented on April 28, 2024

198.2 seems to fail properly, anyways

from flow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.