Comments (7)
I think the only documentation is in the source code:
tl;dr merge
returns a fresh object merge of the operands, copyProperties
mutates the hell out of the first operand and returns it.
from flux.
That makes sense why copyProperties must be called with "new".
Any reason TodoStore
could not be created the same way? I dug into the code a bit and it seems like merge has some specific semantics regarding "merging" objects like arrays, whereas with copyProperties, the second object will overwrite the propery in the first object.
Anyway, this differece would be worth a comment in the code, or if there is no difference, then one technique should be picked.
from flux.
copyProperties
has mostly been replaced by merge
in new code, but there is still a decent amount of older code that hasn't been updated because it works. merge
now being really just an alias for Object.assign
means we may even deprecate those callers and just call it directly. Either way, yes one should be picked but the example app was written months ago and hasn't been updated much.
from flux.
@fisherwebdev @zpao A related question is this declaration in ThreadSection.react.js, line 21
function getStateFromStores() {
return {
threads: ThreadStore.getAllChrono(),
currentThreadID: ThreadStore.getCurrentID(),
unreadCount: UnreadThreadStore.getCount()
};
}
I'm wondering if there was a reason that it was not declared like:
var getStateFromStores = function() {
....
from flux.
Because we wanted to. In general we prefer that style and it does have semantic differences in JS. Here's a deeper dive into the differences: http://javascriptweblog.wordpress.com/2010/07/06/function-declarations-vs-function-expressions/. There are times where your latter example is appropriate.
from flux.
@zpao Very helpful article for a reforming CoffeeScripter-Rails-I-don't-use-modules-nor-Javascript developer! Do you have a link to any style guidelines, especially one that has some "whys"?
from flux.
https://github.com/airbnb/javascript is quite good from what I remember but it's been a while since I looked closely.
from flux.
Related Issues (20)
- Cannot dispatch in the middle of a dispatch. HOT 1
- New Flux store instance created upon second component referencing store HOT 7
- Flux Utils + Hooks HOT 6
- TypeError: Class constructor App cannot be invoked without 'new' HOT 1
- Using version of fbjs that depends on unsupported core-js module HOT 2
- Please update the following components: FluxContainer(containerClass) React 16.10.2 HOT 5
- how do we differ from Architecture and pattern? HOT 1
- Is this code a good way to update react component from dispatch in OOP class object? HOT 2
- Flux container breaks class methods defined with class properties syntax HOT 1
- Container create context issues after Babel 7.9.x update. HOT 5
- CVE-2020-15168 found in [email protected] HOT 13
- CVE-2020-7733 vulnerability by linking to an older fbjs version HOT 2
- Is fbemitter project discontinued? Is flux? HOT 1
- Add React 17 support
- NPM reports flux vulnerabilities HOT 3
- CVE-2021-27292: ua-parser-js needs to upgrade to 0.7.24 HOT 4
- mock flux store - react test HOT 2
- Will there be a Chinese version? HOT 1
- Video goes off screen and does not fit neatly HOT 1
- Add react-18 as peer dependency. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flux.