GithubHelp home page GithubHelp logo

Logic inside actions about flux HOT 2 CLOSED

facebook avatar facebook commented on April 25, 2024
Logic inside actions

from flux.

Comments (2)

fisherwebdev avatar fisherwebdev commented on April 25, 2024

Yes, this is how I would actually build it, but we were trying to show that Web API calls can happen directly out of the action creators. There is nothing wrong with making the call in either place, per se, and sometimes its actually cleaner to do it in the action creators than to do it in the stores.

But the important part is what you have in the comment:

ChatWebAPIUtils.createMessage would trigger an error/success action

I'm open to changing the example, but I do want to keep it as simple as possible.

from flux.

hnordt avatar hnordt commented on April 25, 2024

Hey @fisherwebdev, thank you for your perfect answer.

I get the idea. But looking at the Flux repo, I saw an updated flowchart that makes this clear:

Action creators should be used to call web API, not stores.

This "rule" makes it simple to know what part of the code is calling the web API. As you said, it's actually cleaner to do it in the action creators.

Thank you!

from flux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.