Comments (4)
The dispatcher was designed to be a more abstract component, capable of many uses beyond Flux, and to keep this in sync with Facebook's production code we need to keep it this way. It knows nothing about the payload.type -- a payload may not have a type, if the dispatcher is not being used in a Flux application. So let's remove the ideas here about the action and the type, and just display the whole new payload in the error.
from flux.
Thanks for the feedback. That makes a lot of sense. A couple of questions though:
- I assume we need to pass strings to
invariant()
, so should weJSON.stringify(payload)
? What about potentially big payloads (ex: with large arrays)? - Maybe we can choose to leave the error as-is by default, but if the client passes a
displayPayload
function to theDispatcher
constructor, more error information will be displayed?
from flux.
Re #1, it could be but how big is it really going to be? And at this point you've had something of a critical breakdown anyway so it feels less important that you might be hanging the browser on a long JSON.stringify when your app has effectively already crashed.
Sent from my iPhone
On Nov 9, 2014, at 4:46 PM, Nicolas Hery [email protected] wrote:
Thanks for the feedback. That makes a lot of sense. A couple of questions though:
I assume we need to pass strings to invariant(), so should we JSON.stringify(payload)? What about potentially big payloads (ex: with large arrays)?
Maybe we can choose to leave the error as-is by default, but if the client passes a displayPayload function to the Dispatcher constructor, more error information will be displayed?
—
Reply to this email directly or view it on GitHub.
from flux.
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.
from flux.
Related Issues (20)
- Cannot dispatch in the middle of a dispatch. HOT 1
- New Flux store instance created upon second component referencing store HOT 7
- Flux Utils + Hooks HOT 6
- TypeError: Class constructor App cannot be invoked without 'new' HOT 1
- Using version of fbjs that depends on unsupported core-js module HOT 2
- Please update the following components: FluxContainer(containerClass) React 16.10.2 HOT 5
- how do we differ from Architecture and pattern? HOT 1
- Is this code a good way to update react component from dispatch in OOP class object? HOT 2
- Flux container breaks class methods defined with class properties syntax HOT 1
- Container create context issues after Babel 7.9.x update. HOT 5
- CVE-2020-15168 found in [email protected] HOT 13
- CVE-2020-7733 vulnerability by linking to an older fbjs version HOT 2
- Is fbemitter project discontinued? Is flux? HOT 1
- Add React 17 support
- NPM reports flux vulnerabilities HOT 3
- CVE-2021-27292: ua-parser-js needs to upgrade to 0.7.24 HOT 4
- mock flux store - react test HOT 2
- Will there be a Chinese version? HOT 1
- Video goes off screen and does not fit neatly HOT 1
- Add react-18 as peer dependency. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flux.