Comments (7)
Can you send a PR for what you need?
from folly.
Upon closer look, this won't work on HEAD. I am working on getting it to build cleanly on OSX but the recent dependency on linux/futex.h in detail/Futex.h is making it a little more time consuming than I can handle at the moment. see: #50
I'll try to submit one big OSX compat PR when ready.
from folly.
@yfilali thanks! Keep us posted when you get it.
/cc @danslo who is also working on getting it working on OSX
from folly.
@ptarjan Already fixed it: #67
Haven't looked at building folly independently though, only in the context of HHVM. And we do remove quite a bit in that build.
from folly.
@danslo thanks on the #67 pointer.
Unrelated to the specific MAP_ANON issue, Any thoughts about doing the same for a standalone build on OSX? i.e. simply removing components that don't make sense on other platforms? A lot of the components are pretty platform independent from what I can tell (json, fbstring, endian, hash, etc.).
For example ${FOLLY_DIR}/detail/Futex.cpp is removed from hhvm build which skips the linux/futex.h include issue.
from folly.
Yeah, I have no immediate plans to do that, sorry :-( Because they use different build systems it's also not very easy to port those exclusions over. I'll help out where needed, but my primary focus is on HHVM at the moment.
from folly.
No worries, I am looking at a Makefile.am that already has HAVE_LINUX and !HAVE_LINUX sections. It's probably not as hard as I originally though. The exclusions you pointed me towards are a good start.
from folly.
Related Issues (20)
- Proxygen Linux compilation breaking in folly io_uring
- Compilation error HOT 2
- CommandLineTools 15 possible bug
- coroutine stack overflows
- use of Expected triggers warning
- MPMCQueue blockingRead() doesn't return even with a subsequent write() HOT 1
- packit PR for rpm-build copr build failures, please take a look
- What is the expected behavior of Future::thenInline?
- [build] Build error: link logging_example fail HOT 1
- Possible race condition in ThreadPoolExecutor HOT 1
- `small_vector.MoveAndCopyTrivial` fails with GCC 12.3.0 (no problem with GCC 9.x 10.x 11.x 13.x) HOT 1
- folly::ConcurrentHashMap crashes under high contention HOT 1
- [macOS] `AsyncFdSocket.h: error: 'reinterpret_cast<char*>(15)' is not a constant expression` and other related build errors
- error C2382: 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>::_Eos': redefinition; different exception specifications HOT 7
- undefined reference to `folly::f14::detail::F14LinkCheck HOT 1
- ‘scm_timestamping’ does not name a type
- Is ConcurrentHashMap read lock-free? HOT 2
- Folly fails to build on Windows 11 with build.bat and getdeps.py scripts.
- how to enable folly with sse4.2
- Integrate with google/oss-fuzz for continuous fuzz testing?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from folly.