OS X 10.9.4 - error: constructor priorities are not supported about folly

[ShonM]

Same issue here on 10.9.4 following instructions here

➜  hhvm git:(master) make
[  0%] Built target fastlz
[  0%] Built target afdt
[  5%] Built target mbfl
[  5%] Built target sqlite3
[  6%] Built target timelib
[  6%] Built target lz4
[  6%] Built target double-conversion
[  6%] Building CXX object third-party/folly/CMakeFiles/folly.dir/folly/Version.cpp.o
In file included from /Users/shonm/Sites/hhvm/third-party/folly/folly/Version.cpp:17:0:
/Users/shonm/Sites/hhvm/third-party/folly/folly/VersionCheck.h:78:55: error: constructor priorities are not supported
   __attribute__((constructor(101))) void versionCheck() { \
                                                       ^
/Users/shonm/Sites/hhvm/third-party/folly/folly/Version.cpp:21:1: note: in expansion of macro 'FOLLY_VERSION_CHECK'
 FOLLY_VERSION_CHECK(folly, FOLLY_VERSION)
 ^
make[2]: *** [third-party/folly/CMakeFiles/folly.dir/folly/Version.cpp.o] Error 1
make[1]: *** [third-party/folly/CMakeFiles/folly.dir/all] Error 2
make: *** [all] Error 2

[jwatzman]

I just put up an change for review internally at FB (D1487191) which ifdef's this out on OS X. There appear to be other problems preventing folly from still building even after that fix, but it's a start.

[sinamiandashti]

same here
plz help

[danslo]

@jwatzman Your internal diff, plus the following PR, plus the currently pending weak symbol diff, should be enough to get folly building:
#79

[xavierbaez]

I am having the same problem

[ 17%] Building CXX object third-party/thrift/CMakeFiles/hphp_thrift.dir/lib/cpp/util/FdUtils.cpp.o
Linking CXX static library libhphp_thrift.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libhphp_thrift.a(TTransportException.cpp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libhphp_thrift.a(TTransportException.cpp.o) has no symbols
[ 17%] Built target hphp_thrift
make[1]: *** [third-party/folly/CMakeFiles/folly.dir/all] Error 2
make: *** [all] Error 2

[sinamiandashti]

@chipturner plz review PR

[xavierbaez]

@danslo so you think by the end of this week we'll be able to build HHVM for Mavericks?
I hope so

[jwatzman]

My diff has landed at FB. I'll see if I can poke someone about reviewing that PR and doing another OSS push -- I think folly is still manual at this point?

[sinamiandashti]

how can we build hhvm with newest folly version?
i mean that accepted PR

[danslo]

You can't yet, there's still a number of things that need to happen for HHVM to build cleanly on OSX again: facebook/hhvm#3417