Problems finding libraries with fresh compile under windows about hermes

[tmikov]

Please note that the README of hermes-jsi-demos says:

Building and running the demos has been tested on Linux and macOS, but not on Windows. PRs adding support for Windows are welcome.

Unfortunately, I don't have a Windows development setup readily available, so I can't really debug this. Based on the missing symbols above, can you try adding hermesPublic to this line:
https://github.com/tmikov/hermes-jsi-demos/blob/1fa1c701b3d48b94f5a0a7f630257e9c75a78fcb/hello/CMakeLists.txt#L39

EDIT: also, please note that issues like this should be filed against https://github.com/tmikov/hermes-jsi-demos.

[ClosetGeek-Git]

My presumption is that while on ubuntu that the required libs are being found and linked automatically. I'm very ignorant when it comes to cmake and ninja but I'm presuming this is a configuration deference between ubuntu and windows. I can see where this step could be easier on ubuntu (really, any non-windows platform) because the libs are being compiled as shared libraries where they are all static libs on windows.

[ClosetGeek-Git]

Thank you for your response. I chose to post it here because it seems to be more a question of linking to the existing hermes libraries than something specific to the jsi-demos. I've tried other examples to the same effect. I can see this becoming more of an issue as people will want to build jsi modules without having to build the entire hermes branch.