Comments (2)
Thanks for your question, @jsdario.
At Facebook, we use Flow for type-checking (almost) all of our JavaScript. We generally do not add support for proposals until they are beyond the experimental phase (which I believe is roughly defined as "Stage 2"). Adding support for the existential operator proposal is slightly more involved because it involves changes to not only Flow, but the parser.
The proposal was also not even Stage 1 when we initially introduced idx
into our codebase. And until it is more mature, we need something that allows us to use this pattern while maintaining support with Flow. The benefit of using a function (even one with somewhat arbitrary constraints) is that the tooling ecosystem (e.g. IDEs, linters, and Flow) already know how to work with them.
Some people have raised the point that even though idx
uses valid JavaScript syntax, it still required a custom Flow declaration and Babel plugin. As I mentioned above, the custom Flow declaration was very low cost, and we already have a precedent for Babel plugins that inline code functions in the name of performance (e.g. invariant
).
As soon as the existential operator is further along and supported by Flow, the plan is indeed to codemod all call sites of idx
at Facebook to use it. When that happens, I'll likely also open source the jscodeshift
to do so.
I hope this answers your question!
from idx.
@jsdario for the first question, you can check the issue I made #1. I believe they just didn't know how far the proposal was and the status of it + Babel. Hopefully, we can have better communication in the future
from idx.
Related Issues (20)
- Deprecate? HOT 3
- [TS] v2.5.0 DeepRequired generic breaks input.focus() HOT 3
- Consider to support nullable type in `idx` first argument
- Replace `NonUndefinedOrnNull` with TypeScript standard type `NonNullable` HOT 1
- discussion for setIn implementation? HOT 1
- Typescript types do not work on undefined as first parameter HOT 5
- Upgrade to latest version of Flow HOT 3
- Typescript types do not work on undefined as first parameter (new test case) HOT 4
- Change return value from `T2 | null | undefined` to `T2 | null` and `T2 | undefined`? HOT 1
- Doesn't work with TS compiler HOT 3
- Add support for Map.get in .ts files HOT 2
- Cannot find name 'bigint' HOT 6
- `UnboxDeepRequired doesn't support enum type. HOT 1
- CI is not running test for PRs HOT 1
- Outdated CHANGELOG HOT 1
- New release? HOT 1
- @babel/typescript support HOT 3
- Merge in the macro? HOT 1
- DeepRequiredObject causing issues in Typescript 3.5.1 HOT 2
- Accessing Data on Void HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from idx.