Comments (6)
Hi @mohsen1
I got that already. I just wanted to make sure you are aware of the issue. After all, this is a breaking change for TypeScript users and the version number is increased just as if it is a patch. It will break compilations all over the world and people will have to take action.
If you want to fix this, you can publish a minor release (2.6.0) or, even better a major release (3.0.0), then revert the change and make another patch to the older version (2.5.5). Additionally, this should be documented well to avoid further misunderstandings.
from idx.
I just published [email protected] which includes #80. Thanks everyone!
from idx.
You need to upgrade to TypeScript 3.2
from idx.
With TypeScript and @types/
packages the stance is that your code will break with any change, including patch versions. idx
is shipping it's own types so it's a bit different. That being said, the types here require some minimum version of TypeScript anyways. We're using conditional types that was introduced in TypeScript 3 for instance. We don't want to make TypeScript a peer dependency of idx either, you don't need to have TypeScript to use idx.
I'll leave it to package maintainers to decide. Removing 'bigint'
will not break too many people vs. depending on at least [email protected]
from idx.
I'm down to make the necessary changes for idx
to be compatible with older versions of TypeScript, publish [email protected], and then revert those changes and publish [email protected].
Would either of you be down to make the minimal changes necessary for [email protected]?
from idx.
Thanks @mohsen1 and @yungsters. It is most appreciated.
from idx.
Related Issues (20)
- Deprecate? HOT 3
- [TS] v2.5.0 DeepRequired generic breaks input.focus() HOT 3
- Consider to support nullable type in `idx` first argument
- Replace `NonUndefinedOrnNull` with TypeScript standard type `NonNullable` HOT 1
- discussion for setIn implementation? HOT 1
- Typescript types do not work on undefined as first parameter HOT 5
- Upgrade to latest version of Flow HOT 3
- Typescript types do not work on undefined as first parameter (new test case) HOT 4
- Change return value from `T2 | null | undefined` to `T2 | null` and `T2 | undefined`? HOT 1
- Doesn't work with TS compiler HOT 3
- Add support for Map.get in .ts files HOT 2
- `UnboxDeepRequired doesn't support enum type. HOT 1
- CI is not running test for PRs HOT 1
- Outdated CHANGELOG HOT 1
- New release? HOT 1
- @babel/typescript support HOT 3
- Merge in the macro? HOT 1
- DeepRequiredObject causing issues in Typescript 3.5.1 HOT 2
- Accessing Data on Void HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from idx.