GithubHelp home page GithubHelp logo

Comments (12)

WillianAgostini avatar WillianAgostini commented on May 4, 2024 3

@SimenB @Dreamsorcerer
I found a way to display the total number of pending tests. To achieve this, I had to search within the Jasmine and JestAdapter classes. Below is the screenshot showing the outcome, and here is the commit for the changes in 230b11b.

image

from jest.

WillianAgostini avatar WillianAgostini commented on May 4, 2024

Hi @Dreamsorcerer
What do you think about adding the percentage at the end of the test suite?
See the example below

image

from jest.

Dreamsorcerer avatar Dreamsorcerer commented on May 4, 2024

Anything that shows some progress while it's running would be an improvement. Displaying the results of each test as they complete though, can be more helpful, as you can figure out what test the runner is stuck on (particularly useful in weird edge cases where the runner itself ends up hanging and never completing).

from jest.

WillianAgostini avatar WillianAgostini commented on May 4, 2024

I see that it is better to add it at the end of the Test suite, as placing it next to each test can get confusing when several tests occur in parallel and so this percentage shows the percentage of all tests

from jest.

SimenB avatar SimenB commented on May 4, 2024

I think the request was for progress within a single test file, not the total (which we already have, albeit not as a percentage).

So I think it should be next to a RUNS (and nothing for completed ones) rather than in the summary. Probably behind some sort of option? This feels more line a continuation of #6616 with more precise data rather than doing math on the data we already display

from jest.

Dreamsorcerer avatar Dreamsorcerer commented on May 4, 2024

I misunderstood the original question. The percentage is really not important, you can do whatever you want to do with it (pytest does show the global percentage after each test, but is also, most often, run in a synchronous manner). The main point is that I should be able to see some output after each test, and can figure out which test the runner is stuck on if it were to freeze/crash.

from jest.

WillianAgostini avatar WillianAgostini commented on May 4, 2024

What if we were to add the 'X passed' field next to the path description indicating how many test were completed?
Is this approach useful @Dreamsorcerer @SimenB?
image

from jest.

SimenB avatar SimenB commented on May 4, 2024

Yeah, that looks good to me! Maybe out of a total per test file as well? I think we have this information available

from jest.

Dreamsorcerer avatar Dreamsorcerer commented on May 4, 2024

If you mean that the number is updated as each test passes (as opposed to a total shown at the end of the file run), then that's probably good enough.

from jest.

WillianAgostini avatar WillianAgostini commented on May 4, 2024

@SimenB
Should we exclude the percentage at the conclusion of the test suite?

It would be beneficial to display a percentage out of the total for each test file too but I couldn't locate any property that provides this value before or during the execution of the file.

from jest.

github-actions avatar github-actions commented on May 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from jest.

Dreamsorcerer avatar Dreamsorcerer commented on May 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from jest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.