Contextify breaks with scripts starting with #! about jest

[vjeux]

This is not a valid JavaScript expression so I don't think that contextify nor Jest should be modified to parse it.

preprocessor logic has been designed so that you can workaround those issues. Your preprocessor script is good. And since the only thing it does is to match against a filename and look at the first 2 characters, it shouldn't be a performance issue. If you really want to make it faster you can do a more precise matching like index\.js$.

Do you have another suggestion?

[eendeego]

At least for testing node code there is plenty code around that starts with that sequence, think anything that can be used as a shell script/command.

BTW, a more bullet proof/paranoid version of my code woud be:

module.exports = {
  process: function(src, path) {
    if (path.match(/\.js$/)) {
      if (src.length > 2 & src[0] === '#' & src[1] === '!') {
        var lineBreak = src.indexOf('\n');
        return src.substring(lineBreak === -1 ? '' : lineBreak);
      }
    }
    return src;
  }
};

For reference, take a look at: http://unix.stackexchange.com/questions/65235/universal-node-js-shebang or http://dailyjs.com/2012/03/01/unix-node-arguments/.

[eendeego]

9bcd529 is awesome, but not working for me yet. I'll try to investigate more later (on a stretch now).

[jeffmo]

@luismreis: I just pushed 0.1.14 with aec9875

In my repro case that commit appears to fix the JSONStream issues.
Here's a gist of my repro case for reference: https://gist.github.com/jeffmo/2d0f41bbbe617118ea70

Mind pulling that in and confirming?

[eendeego]

Hi, I've tried 0.1.14 on my project and it worked on the first attempt (except for the ulimit, that I always have to tweak).

I think you can close it. Thanks a lot!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.