Consider upgrading to Jasmine 2 about jest

[chenglou]

👍

[johanneslumpe]

This would be great - being able to use done() for async testing would really be welcome!

[odf]

Any news on that? Ironically, I've found that exactly the tests I moved from plain Jasmine to Jest for in order to simplify my tooling - CSP code that requires ES6 generators - don't work any longer.

[emorikawa]

👍

[osdiab]

I agree! 👍 done() makes async tests so much nicer.

[messfromspace]

👍 I actively use CSP (via js-csp), so it would be pretty nice if I could do something like this:

go(function *() {
  var value;
  value = yield take(makeAsyncThing());
  expect(value).toEqual('whatever');
  done();
});

[NoumanSaleem]

👍 +1

[roderickhsiao]

👍 @jeffmo How do you think

[lo1tuma]

👍

[cirocosta]

👍

[ncuillery]

👍

[fdubost]

Yeah, we need it! 👍

[kennydee]

👍

[oziks]

👍

[cmeiller]

👍

[axross]

👍

[randymorris]

Upgrading to Jasmine 2 would also fix equality issues like the one demonstrated here: https://gist.github.com/randymorris/439a85bccc856ca4e8c1.

[robrobbins]

(thumbsup)
(plusone)
etc...

[robrobbins]

related question: Has anyone dropped in 2.x to see what happens? may not be too bad to fix. OSS and all... (puts on todo list)

[bartgryszko]

👍

[pedroteixeira]

👍

[rosko]

👍

[tewen]

@robrobbins Tried that yesterday. Wanted to limit the amount of time I spent doing it (time boxed to an hour). It's not a simple replacement. I also realized (shortly after) that the jest team would have done this if it was that easy.

👍

[zupzup]

👍

[Cellule]

👍

[zol]

👍

[jeffmo]

Just wanted to follow up here to say that I don't have any immediate plans to build out Jasmine2 support, but only for lack of cycles myself. However, if someone wanted to take a crack at building a jasmine2TestRunner, I'd happily take a PR for such a thing.

You can take a look at the existing jasmineTestRunner:
https://github.com/facebook/jest/blob/master/src/jasmineTestRunner/jasmineTestRunner.js

It should be possible to build a jasmine2TestRunner that matches the same API as that runner function. Then it'll be easy to toggle between the two test runners (and even other test runners!) via this config option:

https://github.com/facebook/jest/blob/master/src/lib/utils.js#L29

[akhomchenko]

Here is WIP update to jasmine 2.x: #330

Help wanted.

[MattyKuzyk]

I was struggling for an hour wondering why my done() wasn't working... ;__;

[akhomchenko]

Optional Jasmine 2.x support was added to #330

Thx to @tomv564

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

[chikamichi]

Well, sir Bot, it's quite a relevant issue still 🍰 but human beings seem to be aware of that wrt #330

[cpojer]

Yes yes, we are working on this. There is a lot of work that we need to do to make jest awesome and I'm still working through the backlog of things we need to do at Facebook. Please have a little bit more patience and I will make sure jest is great soon!

(I assigned this issue to me, hoping that will shut up our bot. cc @vjeux)

[chikamichi]

Oh I'm very patient @cpojer, I just wanted to interact with that inquiring bot of yours :)

[cpojer]

jest 0.8.0 was published just now with optional jasmine2 support! Thanks everyone and I'm deeply sorry for the long wait.

[cpojer]

See http://facebook.github.io/jest/docs/api.html#config-testrunner-string

[catalin-enache]

Thank you so much for Jasmine 2 support !

[quantuminformation]

@cpojer how do I specify this in the command line? I tried this but I still get jasmine1 being used

  "scripts": {
    "test": "jest -testRunner = 'node_modules/jest-cli/src/testRunners/jasmine/jasmine2.js"
  },

[email protected] test /Users/nikos/PhpstormProjects/JestAjaxTest
jest -testRunner = node_modules/jest-cli/src/testRunners/jasmine/jasmine2.js

Using Jest CLI v0.8.2, jasmine1

[catalin-enache]

@quantuminformation
I was able to enable Jasmine2 with the following config:

"jest": {
    "testRunner": "<rootDir>/node_modules/jest-cli/src/testRunners/jasmine/jasmine2.js",
    "scriptPreprocessor": "<rootDir>/node_modules/babel-jest",
    "unmockedModulePathPatterns": [
      "<rootDir>/node_modules/react",
      "<rootDir>/node_modules/react-dom",
      "<rootDir>/node_modules/react-addons-test-utils",
      "<rootDir>/node_modules/fbjs"
    ],
    "moduleFileExtensions": ["js", "jsx"],
    "testFileExtensions": ["js", "jsx"]
  },
"scripts": {
    "test": "jest"
  }

https://github.com/catalin-enache/ab_utils/blob/master/package.json

[cpojer]

You need --testRunner.

[quantuminformation]

I couldn't get --testRunner to run. I needed the extended one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.