GithubHelp home page GithubHelp logo

Comments (4)

Daniel15 avatar Daniel15 commented on April 28, 2024

I do think this has to be changed in recast. @ElonVolo Have we thought about forking recast to roll in changes like this one without having to wait for upstream to merge them?

I personally use parentheses in these cases since it makes the statement less ambiguous :)

from jscodeshift.

techLeadGuy avatar techLeadGuy commented on April 28, 2024

@Daniel15 I also do prefer parentheses for this cases and we'll probably going to use them if no fix can be applied shortly.
I believe I found the culprit in recast and offered to try to fix it, if the authors agree.

It's just that the transformation alters the input in ways we aren't expecting which is a bit scary, especially when applied to a large codebase.

from jscodeshift.

ElonVolo avatar ElonVolo commented on April 28, 2024

from jscodeshift.

techLeadGuy avatar techLeadGuy commented on April 28, 2024

@ElonVolo (coughs awkwardly while looking down) Well, actually.... evcodeshift has the same issue.

from jscodeshift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.