GithubHelp home page GithubHelp logo

Comments (4)

sgrimm avatar sgrimm commented on July 27, 2024

Simple example:

fun splitArgumentListTest(arg1: String, arg2: String, arg3: String, arg4: String, arg5: String, arg6: String, arg7: String) {
  //
}

ktfmt formats this as:

fun splitArgumentListTest(
    arg1: String,
    arg2: String,
    arg3: String,
    arg4: String,
    arg5: String,
    arg6: String,
    arg7: String) {
  //
}

whereas the style guide would suggest:

fun splitArgumentListTest(
    arg1: String,
    arg2: String,
    arg3: String,
    arg4: String,
    arg5: String,
    arg6: String,
    arg7: String
) {
  //
}

from ktfmt.

cgrushko avatar cgrushko commented on July 27, 2024

We do move the closing parenthesis to the next line when there's a type (https://github.com/facebookincubator/ktfmt/blob/fb81db8c849d002c2ae9846eba4607c7d2f2cef6/core/src/test/java/com/facebook/ktfmt/FormatterKtTest.kt#L561), so maybe for consistency's sake we should also do this in this case.

@strulovich, what do you think?

from ktfmt.

strulovich avatar strulovich commented on July 27, 2024

I'm leaning towards changing this as suggested, at least for block functions for now.
I'll take on that.

from ktfmt.

cgrushko avatar cgrushko commented on July 27, 2024

This should now be fixed.

from ktfmt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.