Comments (2)
Looks great!!
Though - one of the stated goals was to avoid exposing configuration (we listed the rationale in the README file), and the plugin sort of circumvents that. ktfmt is OSS, so it's now in the hands of everyone :)
One concern is that we only test two formatting styles - the default one and a so-called "Google" one. We already ran into situations where e.g., having equal block and continuation indents results in visual bugs, so that's something to keep in mind when trying different combinations.
I'd love to collect some feedback and share it with the community.
What did you have in mind?
I'm also wondering if we could link it in the README?
Definitely - do you want to send a PR?
from ktfmt.
Though - one of the stated goals was to avoid exposing configuration (we listed the rationale in the README file), and the plugin sort of circumvents that. ktfmt is OSS, so it's now in the hands of everyone :)
One concern is that we only test two formatting styles - the default one and a so-called "Google" one. We already ran into situations where e.g., having equal block and continuation indents results in visual bugs, so that's something to keep in mind when trying different combinations.
Generally agree. I've tried however to keep consistency with the ktfmt classes visibility. Currently the FormattingOptions
data class is public:
So any other tool that depends on ktfmt has access to it. If this is a concern, that data class should not be exposed. I anyway think it's not a concern as the exposed fields are really limited.
What did you have in mind?
I think that having the project listed in the README is sufficient to create some awareness 👌 Thanks for the opportunity. If users have feedback on the Gradle side, they can definitely open an issue on the repo 👍
from ktfmt.
Related Issues (20)
- Unstable formatting of file with a set of comments HOT 3
- @sample tags should not be moved within kdoc HOT 9
- Formatting creating lines longer than 100 characters HOT 5
- Unexpected removal of space after a comment HOT 2
- Annotation location on properties HOT 1
- Incorrect detection of unused import in Gradle Kotlin DSLs using new assignment operator HOT 1
- Update the pics in [demo](https://github.com/facebook/ktfmt#demo) HOT 4
- Publishing workflow is broken HOT 2
- ktfmt 0.45 is shipping against ancient milestone version of Kotlin HOT 2
- Parse error on empty enum with ';'
- Stop unwrapping wrapped function chaining HOT 1
- Kotlin rangeUntil ..< Syntax Throws Error HOT 1
- Cannot handle formatting `context` keyword HOT 3
- idea complains about deprecated method HOT 5
- KDoc: `@param` and `@property` sorted by type, not by position
- Continuation indent on delegating properties is missing HOT 1
- 0.47 trailing comma changes cause class definitions to be formatted weirdly HOT 2
- Formatting isn't idempotent, and repeated invocations produce bad comment formatting HOT 5
- ktfmt version 0.47 incompatible with spotless HOT 2
- Feature request: GraalVM artifacts HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ktfmt.