GithubHelp home page GithubHelp logo

Standalone Gradle Plugin about ktfmt HOT 2 CLOSED

facebook avatar facebook commented on May 8, 2024
Standalone Gradle Plugin

from ktfmt.

Comments (2)

cgrushko avatar cgrushko commented on May 8, 2024

Looks great!!
Though - one of the stated goals was to avoid exposing configuration (we listed the rationale in the README file), and the plugin sort of circumvents that. ktfmt is OSS, so it's now in the hands of everyone :)
One concern is that we only test two formatting styles - the default one and a so-called "Google" one. We already ran into situations where e.g., having equal block and continuation indents results in visual bugs, so that's something to keep in mind when trying different combinations.

I'd love to collect some feedback and share it with the community.

What did you have in mind?

I'm also wondering if we could link it in the README?

Definitely - do you want to send a PR?

from ktfmt.

cortinico avatar cortinico commented on May 8, 2024

Though - one of the stated goals was to avoid exposing configuration (we listed the rationale in the README file), and the plugin sort of circumvents that. ktfmt is OSS, so it's now in the hands of everyone :)
One concern is that we only test two formatting styles - the default one and a so-called "Google" one. We already ran into situations where e.g., having equal block and continuation indents results in visual bugs, so that's something to keep in mind when trying different combinations.

Generally agree. I've tried however to keep consistency with the ktfmt classes visibility. Currently the FormattingOptions data class is public:

https://github.com/facebookincubator/ktfmt/blob/3b168867acbd34aeb55f83f51416969bc87ac3ed/core/src/main/java/com/facebook/ktfmt/Formatter.kt#L49-L93

So any other tool that depends on ktfmt has access to it. If this is a concern, that data class should not be exposed. I anyway think it's not a concern as the exposed fields are really limited.

What did you have in mind?

I think that having the project listed in the README is sufficient to create some awareness 👌 Thanks for the opportunity. If users have feedback on the Gradle side, they can definitely open an issue on the repo 👍

from ktfmt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.