GithubHelp home page GithubHelp logo

Comments (4)

2wheeh avatar 2wheeh commented on April 27, 2024 1

Hmm the thing was in tsconfig:

"moduleResolution" : "bundler"

It's correctly working on "node", it's probably a bug on tsserver or vscode side.

from lexical.

2wheeh avatar 2wheeh commented on April 27, 2024

.d.ts file in node_modules seems correct though 🤔 :

image

from lexical.

2wheeh avatar 2wheeh commented on April 27, 2024
image image image

It seems to happen to other methods with union return types quite randomly..
.getParent() should have had same type as .getPreviousSibling: LexicalNode | null

and .d.ts looks correct here as well...

image

Is anyone have any clue on this? i checked it happens to other repos running lexical. (I cloned to test 😓)

from lexical.

2wheeh avatar 2wheeh commented on April 27, 2024

I've found the reason !

with moduleResolution: node, the import statement in a .d.ts file resolves '.' to index.d.ts

// something.d.ts
import { /*...*/ } from '.';

However, with moduleResolution: bunder

this path resolves to Lexical.js, which is configured as the main entry in package.json

So, I guess we need to update '.' to './index' to support correct type inference with moduleResolution: bundler.

Or clarify entry for types on package.json ! this would be simpler and more proper solution

from lexical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.