Comments (4)
Hey, was wondering why InternalNode implements both ComponentLayout and ComponentLayout.Builder. Is there any specific reason for this?
Would it make more sense to have one of those classes implemented as a inner/nested class of InternalNode?
If ComponentLayout was a implemented as a inner class, InternalNode.build() could return a new instance of the inner class. The returned object would be immutable. Or similarly, if ComponentLayout.Builder was implemented as a inner class, you get your classic Builder pattern.
Your thoughts? Thanks!
from litho.
As long as we pool and recycle the builder as well as the bested object I think that would be fine. "Locking" the object when it is built is probably much easier to implement though and serves the same purpose as the InternalNode is not a public class.
from litho.
Having a new inner class might be troublesome as ComponentLayout is casted to InternalNode ComponentContext,LayoutState and I'm guessing in a few more places.
Once InternalNode.build() is called, only mutate methods part of ComponentLayout.Builder interface methods should throw an exception right?
For example, in ComponentContext.createLayout, appendComponent() is called on an InternalNode (which had build() called on it). Since appendComponent is not part of ComponentLayout.Builder(), we allow it and don't throw exception.
from litho.
Can be closed since the referencing issue was also closed!
from litho.
Related Issues (20)
- TreeProp updates aren't given to children inside Sections HOT 1
- FrescoImage can't support ScaleType well HOT 3
- visibleHandler and invisibleHandler is not effective HOT 1
- Relocate Litho dependencies in a location other than JCenter. HOT 1
- Paint Flags support HOT 1
- ClickEvent beyond recycler HOT 4
- TextInput with RTL makes ViewPager jump between pages HOT 1
- Elements outside the viewport are not drawn on entering HOT 2
- Litho HOT 1
- Automirrored vector drawables do not get mirrored when layout is RTL HOT 2
- HorizontalScroll should provide the ability to fade edges HOT 3
- how do you update state from a Android Fragment/View parent? like React's useImperativeHandle
- Are there any plans to replace unsupported APIs (KEYCODE_BACK and #onBackPressed) to support Android's new Predictive back gesture?
- OnUpdateState not invoke on parent recycler component
- How to update prop value of MountSpec from LayoutSpec
- How does Litho (Kotlin API) compare to Compose? HOT 1
- Lazy list not working in project getting error HOT 4
- ContentAllocator API not working HOT 14
- NullPointerException in TextDrawable.Draw, seemingly from a race condition in ComponentHost$InterleavedDispatchDraw
- Setting a background to a container using Style.background(dynamicValue: DynamicDrawable) draws outside of bounds of parent. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from litho.