GithubHelp home page GithubHelp logo

Comments (5)

anu0012 avatar anu0012 commented on April 26, 2024 1

Hey @emilsjolander, I want to take up this issue. Can you guide me? Do we need to use bit flags just like it is used in InternalNode.java file?

https://github.com/facebook/litho/blob/master/litho-core/src/main/java/com/facebook/litho/InternalNode.java

from litho.

emilsjolander avatar emilsjolander commented on April 26, 2024

Awesome! Yes I believe so. Will delegate specifics to @mihaelao who is the POC for this issue 👍 She should be able to provide more specific guidance.

from litho.

anu0012 avatar anu0012 commented on April 26, 2024

Hey @mihaelao, I have some doubt regarding this issue. Do we also need to change the return types of methods like callsShouldUpdateOnMount() etc?

from litho.

mihaelao avatar mihaelao commented on April 26, 2024

Hi @anu0012, thanks for taking this up! You're right, the idea is to use bit flags instead of booleans, same as for InternalNode. The API shouldn't change though, those methods should still return booleans, but you can perform bitwise operations on the flags instead of returning the booleans directly.

from litho.

muraziz avatar muraziz commented on April 26, 2024

Resolved with #138

from litho.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.