Address the TODO comment on Table_ddl_manager::put about mysql-5.6

[hermanlee]

Comment by yoshinorim
Wednesday Aug 12, 2015 at 23:52 GMT

---

@maykov Now MyRocks always aborts if dict_manager.commit() fails. Do we still need to fix this?

[alxyang]

came across this comment, while working on inplace alter table. Are we still planning to fix this? Can I assume that dict_manager.commit will not fail (or if it does, MyRocks will abort anyways)

[hermanlee]

I think there is probably enough functionality depending on dict_manager.commit() succeeding that if it fails, MyRocks needs to abort. So you can depend on this requirement. Do others feel this is the case?

[yoshinorim]

MyRocks aborts on dict_manager.commit() errors and we are unlikely to change it. So you can rely on it.

[alxyang]

ok, sounds good.