Update workflow for One Step Build about openr

[butjar]

I created a gist including a script to generate the build script from fbcode_builder: https://gist.github.com/butjar/177871dc7abc7f98c71bcb1dc66d539a.

This solution is a bit dirty and I'm willing to create a clean PR, if you guide me to a good solution. My proposal is updating shell_builder.py to take a parameter (e.g. --system) and return a script that installs OpenR on the system. However, as far as I understood this also requires updating fbcode_builder.py and I'm not sure how much you like to touch the fbcode_builder boilerplate code.

[saifhhasan]

@butjar - If you can try to fix error in build_openr.sh that will be great. Or I can take a look in few days.

Regarding fbcode builder support, I am not much aware of it. You can send a pull request and we can try to consider it. Note that fbcode-builder (same code) is also being used in other facebook opensource projects like folly, fbthrift etc. So if you can add support for installing build artifacts from docker to system generically, then it will be an acceptable solution. Quick glancing shows that you're doing rsync for all /lib and /sbin directories, which might not be a good solution.

[butjar]

I had several problems regarding the dependencies, moreover it seems that the github_hashes get auto-updated. Some dependencies are not frozen at all. I think, the revisions should be build from fbcode_builder/specs for consistency with your main workflow. Updating build_openr.sh will end up in similar problems soon in my opinion.

I agree, the rsync solution is not nice, but a solution installing the artifacts from docker would probably look similar. Maybe generating a deb package from the artifacts might be a good solution.

Unfortunately, the prefix in fbcode_builder.py is hard-coded, that's why it can not be used for a system install. I realized, that fcode builder is boilerplate, this is why I asked before touching it. I still think the shell_builder.py is a good location for auto generation of the build_openr.sh. You might also add the script generation to your CI.