Comments (5)
Likely the entire lib
directory is missed to be checked in?
from pcicrawler.
Thanks for raising the issue. Currently working on removing the reference to pcicrawler.lib
.
from pcicrawler.
Okay! created a pull request with the fix.
from pcicrawler.
@martinezmarcos I see that you have removed the reference to pcicrawler.lib
so the 'master' branch now works. Closing this issue, however having this hard coded return value of 16 is a really bad idea and totally avoidable!
I also, see there is only one place where there is explicit sys.exit
with an error code. Also using 1
or -1
makes more sense for this particular case because semantically it is correct.
$ errno -l | grep EPERM
EPERM 1 Operation not permitted
from pcicrawler.
@gabhijit Thanks for your helpful insight. We will definitely consider the suggestions offered when working on this. For now, removing the reference was the intention. Hope you find the tool helpful and we encourage further contribution!
from pcicrawler.
Related Issues (12)
- Failure when running on ubuntu focal HOT 1
- devices silently dropped when outputting in tree mode
- Renaming master branch to main HOT 1
- pcicrawler is not identifying the speed params correctly for PCIE 5.0 devices HOT 6
- Update for PCIe 5.0 and 6.0 support
- New release since 2021
- Support for AER issues HOT 3
- Remove old facebook CLA
- Root permissions should not be a requirement?
- Add to PyPi HOT 1
- Extend the tool to dump config space
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pcicrawler.