GithubHelp home page GithubHelp logo

Comments (5)

gabhijit avatar gabhijit commented on April 25, 2024

Likely the entire lib directory is missed to be checked in?

from pcicrawler.

martinezmarcos avatar martinezmarcos commented on April 25, 2024

Thanks for raising the issue. Currently working on removing the reference to pcicrawler.lib.

from pcicrawler.

gabhijit avatar gabhijit commented on April 25, 2024

Okay! created a pull request with the fix.

from pcicrawler.

gabhijit avatar gabhijit commented on April 25, 2024

@martinezmarcos I see that you have removed the reference to pcicrawler.lib so the 'master' branch now works. Closing this issue, however having this hard coded return value of 16 is a really bad idea and totally avoidable!

I also, see there is only one place where there is explicit sys.exit with an error code. Also using 1 or -1 makes more sense for this particular case because semantically it is correct.

$ errno -l | grep EPERM
EPERM 1 Operation not permitted

from pcicrawler.

martinezmarcos avatar martinezmarcos commented on April 25, 2024

@gabhijit Thanks for your helpful insight. We will definitely consider the suggestions offered when working on this. For now, removing the reference was the intention. Hope you find the tool helpful and we encourage further contribution!

from pcicrawler.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.