GithubHelp home page GithubHelp logo

Comments (5)

ljharb avatar ljharb commented on May 24, 2024 1

No, you’re not correct. You control when it’s created - react controls when it’s mounted.

from prop-types.

ljharb avatar ljharb commented on May 24, 2024

This error comes from React, not this library.

However I'm pretty sure that propTypes fire when the element is created, not when it's rendered, so you can find the error sooner.

A better solution is to not render the Child elements at all when title is falsy.

Closing, since it's not a prop-types issue specifically.

from prop-types.

SonyaOrlova avatar SonyaOrlova commented on May 24, 2024

Hi, what do you mean by "when the element is created"? The element is not even mounted in this case, why propType is checked? Have the same problem

from prop-types.

ljharb avatar ljharb commented on May 24, 2024

They’ve always been checked when the element is created - which for jsx, is the moment the jsx is evaluated.

from prop-types.

SonyaOrlova avatar SonyaOrlova commented on May 24, 2024

thanks for feedback

it seems that the check is needed when the component is mounted, because for a developer the component exists when it is mounted - that is the moment we can control

from prop-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.