Comments (6)
If there is a reason that we would want to expand that list of prior scales in the future past weekly seasonality, yearly seasonality, changepoint and holiday it might be good to make it a list.
One scenario I can think of is if you have a large list of holiday components and you want to weight them differently you may want to list those weights in a more general prior_scales list.
One drawback of using this prior_scales list is that it's a less standard input and if you are tailoring this to be easy to use and automatic this added complexity of arguments may be prohibitively complex.
from prophet.
I wonder if it might make sense to make more generic, like prior_scales = list()
.
from prophet.
Definitely agree, would like to only decrease yearly.seasonality.prior.scale but not the weekly one.
from prophet.
Would anyone like to make a PR for this in the v0.2 branch? It would need to be on top of the add_regressor
feature (8f1607c), which makes it more convenient to have prior scales with different values. This has been done for Python but is not yet in the R version (see #101).
-
For holidays, I think we could add an optional column to the dataframe
prior_scale
(optional likelower_window
andupper_window
) which specifies the prior_scale for each holiday if given, and otherwise it defaults to holidays_prior_scale. There should be validation that a single prior scale is specified for each holiday. Themake_holiday_features
method could return the prior scales in a list, which could then immediately be used bymake_all_seasonality_features
as-is. -
Custom seasonalities (via
add_seasonality
) should be able to specify the prior scale, but then default to seasonality_prior_scale if not provided. -
There are three built-in seasonalities: yearly, weekly, and daily. Of the options discussed above, the cleanest seems to me to be having three corresponding arguments to Prophet(), yearly_seasonality_prior_scale, yearly_seasonality_prior_scale, and yearly_seasonality_prior_scale. I do worry about cluttering it with too many arguments, but also wouldn't want to sacrifice clarity and ease-of-use over two arguments. Any other thoughts on this?
from prophet.
This is done in Py with a620a6c and 8d27643 and can be ported to R once #278 is finished. I'll add documentation for it then.
from prophet.
This can now be done in v0.2 available in CRAN and pypi. Documentation is here:
https://facebookincubator.github.io/prophet/docs/seasonality_and_holiday_effects.html
If you have any issues with it feel free to reopen here, or to make a new issue.
from prophet.
Related Issues (20)
- I have a issue in installation of prophet library HOT 2
- error in pip install pystan, cython was installed, does anyone know how to solve it?
- Fit params for kwargs
- fbprophet installing error HOT 1
- RuntimeError: Error during optimization: console log output: dyld[10867]: Symbol not found
- pip install guardrails getting this error HOT 2
- Prophet Training Speed: Intel vs Apple M1/M2 HOT 2
- RuntimeError: Error during optimization! HOT 3
- fbprophet install error fix
- BUG - Cannot predict on using logistic -> All-NaN slice encountered HOT 1
- Add interactions to weekly/daily periods for hourly univariate time series data
- [BUG] Zero Division in diagnostics.performance_metrics() causing failed assertion
- Using prophet 1.1.4 (python), is it possible to get "adapt_delta" passed down to stan as part of the "fit" call?
- I am a beginner and I do not know How to solve this Error HOT 5
- Loading META Prophet model gives a tz, datetime error HOT 1
- select_()` was deprecated in dplyr 0.7.0
- How to add some new E-commerce holidays for one country HOT 2
- KeyError: 'k' missing
- prophet uses deprecated numpy np.float/int aliases HOT 1
- Covid One Off Holidays HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prophet.