SPDYCodecTest.HeaderWithManyValues test fails on Ubuntu > 14 about proxygen

[w-o-o]

@js7222 , I cannot reproduce your problem in my dev server. I am happy to investigate this further if you can provide more details about how to reproduce this.

proxygen/lib/http/codec/test/CodecTests --gtest_filter=SPDYCodecTest.HeaderWithManyValues -v 4
Note: Google Test filter = SPDYCodecTest.HeaderWithManyValues
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SPDYCodecTest
[ RUN ] SPDYCodecTest.HeaderWithManyValues
V1228 13:45:14.245183 3819173 SPDYCodec.cpp:196] creating SPDY/3.0 codec
V1228 13:45:14.245311 3819173 SPDYCodec.cpp:196] creating SPDY/3.0 codec
V1228 13:45:14.247814 3819173 SPDYCodec.cpp:534] Dropping SPDY reserved header Host
V1228 13:45:14.249593 3819173 GzipHeaderCodec.cpp:280] header size orig=9032, max deflated=10314, actual deflated=9134
V1228 13:45:14.249876 3819173 SPDYCodec.cpp:1208] Got SYN_STREAM, stream=1 pri=0
[ OK ] SPDYCodecTest.HeaderWithManyValues (6 ms)
[----------] 1 test from SPDYCodecTest (6 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (6 ms total)
[ PASSED ] 1 test.

[js7222]

I literally just ran ./deps.sh && ./reinstall.sh as per the instructions. I am using Ubuntu 15.10. Is there anything specific you would like me to provide?

[kwlo]

I got the same error messages as js7222 as well. Didn't modify anything. Just git cloned and ./deps.sh.
Ubuntu 15.10

[kwlo]

It seems this issue is caused by Ubuntu 15.10. I am able to build successfully with 14.04

[w-o-o]

@kwlo thanks for feedback. Our current internal testing environment is Ubuntu 14.04 LTS. Let me try to get 15.10 to reproduce it.

meanwhile, welcome to send us a pull request if you figure out the fix.

[byronhe]

reproduced on Ubuntu 15.10, X86_64.

did some debug , looks like this test case failed:

    TEST(SPDYCodecTest, HeaderWithManyValues) 

https://github.com/facebook/proxygen/blob/master/proxygen/lib/http/codec/test/SPDYCodecTest.cpp#L517

the reason is SPDYUtil::validateHeaderValue() return false,
name is "host"
value is '\001' <repeats 11 times>

    valueOk = SPDYUtil::validateHeaderValue(value, SPDYUtil::STRICT);

https://github.com/facebook/proxygen/blob/master/proxygen/lib/http/codec/SPDYCodec.cpp#L1044

          if (*p < 0x20 || *p == 0x7f) {
            // unexpected ctl per rfc2616
            return false;
          }

https://github.com/facebook/proxygen/blob/master/proxygen/lib/http/codec/SPDYUtil.h#L104

[nitingupta910]

I get exactly the same failure on Ubuntu 16.04 (alpha).

[afrind]

I've created a task internally to add support to these newer ubuntu revs, but it might take a while to get to them. Would gladly accept a PR :)

[afrind]

I just built a new Ubuntu 16.04 VM and ran deps.sh && resinstall.sh from HEAD and it worked. I even ran the SPDYCodecTests with a CPU intensive job in the background to see if CPU load affected it. I built with gcc-5.4.

Given the comment from @byronhe I wonder if it might be somehow locale dependent? Can folks post if they are still seeing this on recent ubuntu?

[afrind]

Old issue, cannot repro.