GithubHelp home page GithubHelp logo

Pyre vs mypy about pyre-check HOT 4 CLOSED

facebook avatar facebook commented on April 27, 2024 44
Pyre vs mypy

from pyre-check.

Comments (4)

dkgi avatar dkgi commented on April 27, 2024 17

Thanks, though this does not really answer what's wrong with contributing to mypy, for example helping to make it faster. There seems to be no reason why your (very cool!) static analysis tools wouldn't work with any type checker. After all they only care about the end result: the resolved types of functions and variables.

@ze-phyr-us: there's nothing wrong with contributing to mypy ;) We decided not to because for two main reasons:

  1. we believe there are fundamental limitations to what you can achieve in terms of performance in a tool written in Python. I'm sure it's possible replicate the lock free shared-memory / multiprocessing architecture in Python but that leads to
  2. we do have a lot of the infrastructure for this already in place from the Hack type checker. On top of the parallelization we can also reuse parts of the deeper static analysis we're running on our PHP codebase that we haven't been able to open source before.

from pyre-check.

vitawasalreadytaken avatar vitawasalreadytaken commented on April 27, 2024 16

Thanks, though this does not really answer what's wrong with contributing to mypy, for example helping to make it faster. There seems to be no reason why your (very cool!) static analysis tools wouldn't work with any type checker. After all they only care about the end result: the resolved types of functions and variables.

Don't get me wrong – I am glad that gradual typing is gaining so much traction in the Python world. But as I understand it writing a good type checker for Python is a massive undertaking – judging by the number of issues Mypy has and which we run into almost daily when using it at work. So clearly your decision to write your own was not taken lightly, and I am wondering why you decided Mypy wasn't worth the effort.

from pyre-check.

gnprice avatar gnprice commented on April 27, 2024 5

I'm not affiliated with the Pyre team, but you may find these comments helpful from one of them: https://news.ycombinator.com/item?id=17048682

To summarize: the "overriding concern" was

We are building deeper semantic static analysis tools on top of Pyre. We've built some of these tools for Hack/PHP already, so following the Hack type checker's architecture is the best way for us to achieve this.

from pyre-check.

dkgi avatar dkgi commented on April 27, 2024 3

I think @phooji's comment on Hackernews captures the basic motivation. He also gave a talk at PyCon providing more context around the direction we're taking here: https://www.youtube.com/watch?v=hWV8t494N88

from pyre-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.