GithubHelp home page GithubHelp logo

Comments (15)

zpao avatar zpao commented on April 27, 2024

@sebmarkbage

from react-devtools.

mckelvey avatar mckelvey commented on April 27, 2024

Iā€™m having the same experience; same versions noted above. In-page react is version 0.11.1.

from react-devtools.

HurricaneJames avatar HurricaneJames commented on April 27, 2024

I think this is related to #50

from react-devtools.

jgebhardt avatar jgebhardt commented on April 27, 2024

Same here; fwiw, key bindings still work.

from react-devtools.

super-cache-money avatar super-cache-money commented on April 27, 2024

Me too...

from react-devtools.

mmahalwy avatar mmahalwy commented on April 27, 2024

Same here!

from react-devtools.

jeroencoumans avatar jeroencoumans commented on April 27, 2024

In the Extension inspector, it fails in treeoutline.js line 943:

Uncaught TypeError: undefined is not a function
TreeElement.isEventWithinDisclosureTriangle
TreeElement.treeElementMouseDown
TreeElement.prototype.isEventWithinDisclosureTriangle = function(event)
{
    // FIXME: We should not use getComputedStyle(). For that we need to get rid of using ::before for disclosure triangle. (http://webk.it/74446) 
    var paddingLeftValue = window.getComputedStyle(this._listItemNode).getPropertyCSSValue("padding-left");
    var computedLeftPadding = paddingLeftValue ? paddingLeftValue.getFloatValue(CSSPrimitiveValue.CSS_PX) : 0;
    var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding;
    return event.pageX >= left && event.pageX <= left + this.arrowToggleWidth && this.hasChildren;
}

I've managed to get my local installation working by changing line 943 to var paddingLeftValue = 0;. This is in the blink snapshot from the devtools, so I'm guessing a proper fix would be to include a newer snapshot which works with Chrome >= 40.

from react-devtools.

TrySpace avatar TrySpace commented on April 27, 2024

Same here, two different computer with latest Chrome (40.0.2214.91)
Elements in the React tab are reacting to hover, but not clicking. You can change selection of elements with arrow keys though. But the props and state are not clickable or expanding.
@jeroencoumans your solution works!
We can edit the plugin for now: http://stackoverflow.com/questions/2250163/how-do-i-directly-modify-a-google-chrome-extension-file-crx

from react-devtools.

dmnd avatar dmnd commented on April 27, 2024

I hit this in Canary months ago and stopped using it for dev because of this issue. Now it's made it to stable šŸ˜¢

from react-devtools.

zpao avatar zpao commented on April 27, 2024

@jeroencoumans Thanks for hunting that down. I think @sebmarkbage was working on a fix, which might be to update the blink tools. Though in the mean time, it might be a good idea to take the minimal fix in the short term though. What do you think Sebastian?

from react-devtools.

sebmarkbage avatar sebmarkbage commented on April 27, 2024

This was hotfixed. I should've caught it earlier but Chrome breaks a lot of things in Beta that never makes it into the public release. Sorry for the inconvenience.

from react-devtools.

dmnd avatar dmnd commented on April 27, 2024

Today I have 0.12.2 installed (updated Jan 28) but this issue seems to persist? @sebmarkbage should this be working now?

from react-devtools.

mckelvey avatar mckelvey commented on April 27, 2024

I am seeing this working correctly. Versions: 0.12.2 on 40.0.2214.91 and 40.0.2214.93

from react-devtools.

dmnd avatar dmnd commented on April 27, 2024

Oh, actually, this works for me too after a restart of Chrome. I guess
extension updates need that sometimes?

Anyway, thanks for React <3

On 28 January 2015 at 20:06, David W. McKelvey [email protected]
wrote:

I am seeing this working correctly. Versions: 0.12.2 on 40.0.2214.91 and
40.0.2214.93

ā€”
Reply to this email directly or view it on GitHub
#62 (comment)
.

from react-devtools.

RoDo777 avatar RoDo777 commented on April 27, 2024

Having similar problems: The react tab is there, but nothing inside the pane.
Tried everything here - _update components, edit line 943, make own package,restart chrome.
Even in Chrome 38.0.x.x it is the same. _Could it be a different registry setting?*

Chrome Version 40.0.2214.111 m - React Developer Tools 0.13.0 - Windows 7 SP 1
I'm also not behind a firewall.

Is there a way to put a trace inside the scripts to get closer to the problem?

By the way, when I tried to install my package it says "Cannot load extension with file or directory name metadata. Filenames starting with "" are reserved for use by the system"
Renamed it to "metadata", but I think thats not working, even the package then gets installed.

At home on my notebook, with win7, same chrome and Devtool versions it works
But I need to have it work at work ...

from react-devtools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.