GithubHelp home page GithubHelp logo

Android events don't get fired using mEventDispatcher.dispatchEvent with the New Architecture and bridgeless off about react-native HOT 4 CLOSED

gabrieldonadel avatar gabrieldonadel commented on April 27, 2024
Android events don't get fired using mEventDispatcher.dispatchEvent with the New Architecture and bridgeless off

from react-native.

Comments (4)

cortinico avatar cortinico commented on April 27, 2024 1

@gabrieldonadel Thanks for the reproducer it was extremely valuable for me to isolate the issue. A fix is forthcoming

from react-native.

javache avatar javache commented on April 27, 2024

Noticed that in your sample, your accessing the event emitter here.

mEventDispatcher = UIManagerHelper.getEventDispatcherForReactTag((ReactContext) getContext(), getId());

I don't believe this is safe, as at this point RN will not have initialized the Id field yet, and we'll fall back to the paper event dispatcher even if this is a Fabric view.

from react-native.

gabrieldonadel avatar gabrieldonadel commented on April 27, 2024

Noticed that in your sample, your accessing the event emitter here.

mEventDispatcher = UIManagerHelper.getEventDispatcherForReactTag((ReactContext) getContext(), getId());

I don't believe this is safe, as at this point RN will not have initialized the Id field yet, and we'll fall back to the paper event dispatcher even if this is a Fabric view.

I see, thanks for the explanation. If the UIManagerHelper.getEventDispatcherForReactTag call were to only occur inside the action event (e.g. onClick) this would be fine, right?

from react-native.

cortinico avatar cortinico commented on April 27, 2024

I see, thanks for the explanation. If the UIManagerHelper.getEventDispatcherForReactTag call were to only occur inside the action event (e.g. onClick) this would be fine, right?

Yup I've tested this in your repro and it effectively fixes the issue 👍

from react-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.