Comments (4)
@gabrieldonadel Thanks for the reproducer it was extremely valuable for me to isolate the issue. A fix is forthcoming
from react-native.
Noticed that in your sample, your accessing the event emitter here.
mEventDispatcher = UIManagerHelper.getEventDispatcherForReactTag((ReactContext) getContext(), getId());
I don't believe this is safe, as at this point RN will not have initialized the Id field yet, and we'll fall back to the paper event dispatcher even if this is a Fabric view.
from react-native.
Noticed that in your sample, your accessing the event emitter here.
mEventDispatcher = UIManagerHelper.getEventDispatcherForReactTag((ReactContext) getContext(), getId());
I don't believe this is safe, as at this point RN will not have initialized the Id field yet, and we'll fall back to the paper event dispatcher even if this is a Fabric view.
I see, thanks for the explanation. If the UIManagerHelper.getEventDispatcherForReactTag
call were to only occur inside the action event (e.g. onClick) this would be fine, right?
from react-native.
I see, thanks for the explanation. If the
UIManagerHelper.getEventDispatcherForReactTag
call were to only occur inside the action event (e.g. onClick) this would be fine, right?
Yup I've tested this in your repro and it effectively fixes the issue 👍
from react-native.
Related Issues (20)
- Appearence. addChangeListener does not reacts to changes of the themes change on OS after Appearance.setColorScheme was used and reacts only to Appearance.setColorScheme HOT 2
- ModuleNotFoundError: Module not found: Error: Can't resolve '../Utilities/Platform' HOT 4
- scrollview glitches after overscrolling to the top of view HOT 1
- Fabric component custom properties, when one property is modified by JavaScript using setState, all property set methods in Android bridging are invoked. HOT 6
- Animation artifacting HOT 2
- Pressing reload on the error screen does not connect to metro HOT 1
- I followed the steps and did the pod install but still my project is failing to load on iOS. HOT 6
- Chain validation failed HOT 3
- [Codegen] overloaded fromRawValue across modules for ArrayEnum props with type alias uint32_t cause runtime crash HOT 7
- Object not shown as needed in new debugger HOT 2
- Hot reload not working on physical device HOT 3
- <Image> events are missing payload data on iOS HOT 1
- When Nesting a Flatlist inside a Flatlist both are horizontal child flatlist in not rendering horizontally HOT 4
- Multiline and returnLabelType="send' not working together? HOT 4
- TypeError: pressability.getEventHandlers is not a function HOT 2
- "Loading from Metro" banner rendering twice and remaining visible for ~15 seconds on each reload HOT 1
- App.tsx seems to run before index.js HOT 1
- "error: index.js: api is not defined" ERROR in React Native HOT 2
- Headless JS fails after 1 minute of usage HOT 11
- NSInternalInconsistencyException: UIGraphicsBeginImageContext() failed to allocate CGBitampContext: size={390, 0}, scale=3.000000, bitmapInfo=0x2006. Use UIGraphicsImageRenderer to avoid this assert. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native.