Comments (3)
I think it's a very clever idea and I like reducing RCTJavaScriptExecutor
protocol. However, the code in the bundle has to define a global require
function that will be used by ObjC to invoke JS methods. Also there are benefits for the existing model, for example Chrome debugger integration (not in the oss repo yet) that runs the JS code in a Chrome page. The app bundle in this case is loaded via <script>
tag instead of being passed via websockets.
from react-native.
Could the JS application engine be set up by passing in a global object? For example:
(function(global) {
// Make require.js use "global", which passes it to all of the module factory functions.
// require.js also sets "global.require", "global.requireLazy", etc...
});
From the native side, the application engine is initialized like:
// Create a "global" object. May need to have it act as a proxy to the real global object
// and would need to write a little more code for that.
JSValue *reactGlobal = [JSValue valueWithNewObjectInContext:context];
reactGlobal[@"__fbBatchedBridgeConfig"] = bridgeConfigDictionary;
[[context evaluateScript:bundleScriptString] callWithArguments:@[reactGlobal]];
Accessing the global require
function from Obj-C is simple as well:
JSValue *exports = [reactGlobal[@"require"] callWithArguments:@[@"moduleName"]];
[exports invokeMethod:@"doSomething" withArguments:@[...]];
So in the end, RCTJavaScriptExecutor
has a smaller API and ReactKit is better encapsulated by reducing pollution of the global scope (some functions like setTimeout need another approach though).
For the Chrome debugger extension, it might be possible to keep using the real global object with the help of the packager by serving (function(global) { /* ... */ })(window);
.
from react-native.
Closing for now since it doesn't sound like this is blocking anything.
from react-native.
Related Issues (20)
- REACT NATIVE 0.74.3 Signed Release APK Issue HOT 5
- [IOS] Compile Issue. It was working fine previously but now it stops working. HOT 2
- java.lang.Exception: React Native needs Node.js >= 18 HOT 5
- backgroundColor is not being applied to Text and View when giving borderStyle as 'dotted' or 'dashed' HOT 2
- Xcode Unsupported Swift Version HOT 3
- Execution failed for task ':app:compileDebugJavaWithJavac'. HOT 2
- How to use https agent in React Native? HOT 4
- NativeModules is {} HOT 1
- Platform.constants.reactNativeVersion.prerelease should be a string HOT 5
- App restarts / crashes when enabling remote debugging with RN 0.73.9 for Android HOT 4
- 0.75.0-rc.4 - App build failed for task ':app:generateAutolinkingPackageList'. HOT 12
- `headers` defined in Image `source` prop are not sent along with the request for a remote image HOT 3
- Invariant Violation: "App" has not been registered. This can happen if: * Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project. HOT 2
- AppState 'change' fires redundant 'active' when app is already active the first time the listener is added on Android iOS Prod HOT 3
- Build failure in Fabric when implementing custom Shadow Node with Swift integration
- build error HOT 3
- Strange Issue with PagerView/Image in a Full Screen Overlay (iOS only) HOT 3
- TextInput menu is not hidden even contextMenuHidden is true on Android HOT 2
- onEndReached does not trigger even though onEndReachedThreshold is set HOT 2
- [iOS] Hash Generated Using Broken Cryptography API (SHA1) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native.