GithubHelp home page GithubHelp logo

Comments (4)

hansottowirtz avatar hansottowirtz commented on June 23, 2024

This patch solves it:

--- a/dist/compiled/react-dom/cjs/react-dom.development.js
+++ b/dist/compiled/react-dom/cjs/react-dom.development.js
@@ -30987,7 +30987,16 @@ function replaySuspendedUnitOfWork(unitOfWork) {
         var Component = unitOfWork.type;
         var unresolvedProps = unitOfWork.pendingProps;
         var resolvedProps = unitOfWork.elementType === Component ? unresolvedProps : resolveDefaultProps(Component, unresolvedProps);
-        next = replayFunctionComponent(current, unitOfWork, resolvedProps, Component, workInProgressRootRenderLanes);
+        var componentRender = null;
+        switch (unitOfWork.tag) {
+          case FunctionComponent:
+            componentRender = type;
+            break;
+          case ForwardRef:
+            componentRender = type.render;
+            break;
+        }
+        next = replayFunctionComponent(current, unitOfWork, resolvedProps, componentRender, workInProgressRootRenderLanes);

A line like this exists in updateForwardRef, but doesn't seem to exist in the replay suspense logic.

const render = Component.render;

from react.

hansottowirtz avatar hansottowirtz commented on June 23, 2024

@acdlite tagging you because I think the reconciler and suspense is your field of expertise. Happy to help with anything that can help solve this.

from react.

acdlite avatar acdlite commented on June 23, 2024

Ah yeah that's a good find. Want to submit a PR with a regression test? :)

from react.

hansottowirtz avatar hansottowirtz commented on June 23, 2024

Sure! Might need some help on how to trigger the replaySuspendedUnitOfWork function. I'll tag you in the PR.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.