GithubHelp home page GithubHelp logo

Comments (3)

gaearon avatar gaearon commented on April 24, 2024

It's described in more detail here:

I agree it's not immediately obvious. The canonical solution for your case is to extract components like SettingsForm / SignupForm, for example.

It might be a good idea to mention it in "conditional rendering" but I'm worried it's a bit much at that stage.

from react.

johtso avatar johtso commented on April 24, 2024

@gaearon thanks for the thoughtful reply!

This section definitely covers these issues:

The only thing that doesn't seem clear to me is what is considered the identity of a native element. "when you render a different component in the same position, it resets the state of its entire subtree"

Intuitively you'd think that different types of input/button element would be considered different for the purposes of rendering. If it's literally just the element that's taken into consideration, then maybe the page could mention that and when that might be surprising (maybe using submit/button buttons as an example).

Hope this input is helpful!

from react.

johtso avatar johtso commented on April 24, 2024

@gaearon also, this was the use case:

There's obviously lots of ways I could have modelled this that wouldn't have stumbled into this issue. I could have just hidden the password field instead of not rendering it, and used a value on the submit button to help the server distinguish the type of login.

To be honest I'm still not clear on how React models the "tree" to decide if a element is in the same place as a previous element. Looking at my implementation I still don't see why the presence of the password input field affects the identity / position in the tree of the two buttons.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.