GithubHelp home page GithubHelp logo

Comments (5)

s100 avatar s100 commented on April 24, 2024 2

Thank you very much for the workaround! In practice I found that simply unrefing the port immediately on creation did not do the trick, because as soon as scheduler calls channel.port1.onmessage = performWorkUntilDeadline the port becomes reffed again. I had to do something more complex:

const MessageChannelOriginal = global.MessageChannel
global.MessageChannel = class {
  constructor () {
    const channel = new MessageChannelOriginal()
    this.port1 = new Proxy(channel.port1, {
      set (port1, prop, value) {
        const result = Reflect.set(port1, prop, value)
        if (prop === 'onmessage') {
          port1.unref()
        }
        return result
      }
    })
    this.port2 = channel.port2
  }
}

Alternatively, as I happen to be using Mocha, I found that the --exit flag also worked.

from react.

victor-homyakov avatar victor-homyakov commented on April 24, 2024 1

@victor-homyakov Are you aware of any kind of workaround for this?

The workaround is to use patched MessageChannel in JSDom, something like

const MessageChannelOriginal = require('node:worker_threads').MessageChannel;
class MessageChannel {
    constructor() {
        const channel = new MessageChannelOriginal();
        // Allow the thread to exit if this is the only active handle in the event system
        if (channel.port1.unref) {
            channel.port1.unref();
        }
        this.channel = channel;
    }
    get port1() {
        return this.channel.port1;
    }
    // ...
}
window.MessageChannel = MessageChannel;

from react.

s100 avatar s100 commented on April 24, 2024

I'm seeing the same issue during some experiments with Mocha testing. The suggested fix works for me. I will produce a minimal repro if that's considered desirable.

@victor-homyakov Are you aware of any kind of workaround for this?

from react.

github-actions avatar github-actions commented on April 24, 2024

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

from react.

s100 avatar s100 commented on April 24, 2024

Bump, this is still an issue for us.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.