Comments (11)
@gaearon <link rel="modulepreload" />
tags are being moved to before <link rel="stylesheet" />
tags. Since stylesheets are blocking, if you have a decent amount of modulepreloads then you end up delaying the initial render by however long it takes the browser to free up a network connection to fetch the stylesheet due to all the in-flight preloads.
I think modulepreloads should ideally be moved to after the last stylesheet link tag, which would let the browser fetch the blocking CSS as fast as possible before attempting to preload any JS modules, which can occur asynchronously and won't block the initial paint.
from react.
Ideally React fixes this by automatically prioritizing stylesheets over modulepreloads and a workaround isn't needed.
However to move the stylesheets above the modulepreloads in the meantime, you can add a precedence: 'high'
attribute on stylesheet links from the Remix links function. I don't think this is documented but I learnt it from the React unit tests.
e.g.
export const links: LinksFunction = () => [
{ rel: 'stylesheet', href: appStylesHref, precedence: 'high' },
];
Will result in the stylesheet link being placed at the top of the head element, above the modulepreloads.
<head>
<meta charSet="utf-8"/>
<meta name="viewport" content="width=device-width,initial-scale=1"/>
<link rel="stylesheet" href="/build/_assets/app-B5PUCUEH.css" data-precedence="high"/>
<title>New Remix App</title>
<meta name="description" content="Welcome to Remix!"/>
<link rel="modulepreload" href="/build/entry.client-4MXBZIKC.js"/>
<link rel="modulepreload" href="/build/_shared/chunk-PNG5AS42.js"/>
<link rel="modulepreload" href="/build/root-XKG6C447.js"/>
<link rel="modulepreload" href="/build/routes/_index-T377ZUPD.js"/>
</head>
from react.
the link order is important cause we want to preload some critical image to decrease the LCP time
from react.
downgrade the version to 18.2.0, and the order is expected.
from react.
Hi @lili21 , i am new to open source could i get a chance to work on this issue?
from react.
When you say "messed up" do you mean some tags or missing? Or can you be more specific?
from react.
the order of links is not expected.
from react.
those <link rel=modulepreload />
tags have been moved into head
, which should be in body
.
from react.
it's hurting our performance. you can check the similar problem with vitejs/vite#5120.
after upgrade to react@canary version, we see the same effect in production, the FCP increase about 1s. because all the <link rel=modulepreload />
have been moved into head.
from react.
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!
from react.
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!
from react.
Related Issues (20)
- [React 19] Inconsistent "cache" api with Async Operations in react-server HOT 2
- [Compiler Bug]: Increment expression in for-loop loses assignment operation HOT 4
- Bug: TypeError: Cannot read properties of null (reading 'useState')
- Ensures role attribute has an appropriate value for the element (aria-allowed-role - https://dequeuniversity.com/rules/axe/4.7/aria-allowed-role?application=msftAI) HOT 1
- Ensures ARIA attributes are allowed for an element's role (aria-allowed-attr - https://accessibilityinsights.io/info-examples/web/aria-allowed-attr)Bug: HOT 1
- Bug: HOT 1
- [VLG]¿Cómo hablar con Vueling por teléfono? @telefono españa HOT 1
- hook invalid
- Feature request: Expose additional profiling tools for library testing HOT 5
- Bug: "Should have a queue. This is likely a bug in React" HOT 11
- [React 19]
- [React 19] requestFormReset reports TypeError Cannot read properties of null (reading 'queue') on repeated form submissions HOT 3
- [Compiler Bug]: healthcheck do not check next.js StrictMode HOT 5
- [React 19] Different behaviors with `preload` method HOT 2
- Bug: React 18 SSR Sometimes fallback to CSR without throw any errors on Prod Mode, The fiber node which tag is "HostRoot"(3)has flags "Snapshot"(1024),it works fine when flags is Update(4) HOT 1
- Bug: ForwardRef components cant have display names or types HOT 2
- Consider changing the next property type of the update object of the dispatchSetState function from any to null
- [React 19]
- ..
- [DevTools Bug]: 5.2.0 is not available for Firefox HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.