GithubHelp home page GithubHelp logo

Comments (8)

lili21 avatar lili21 commented on October 3, 2023

the link order is important cause we want to preload some critical image to decrease the LCP time

from react.

lili21 avatar lili21 commented on October 3, 2023

downgrade the version to 18.2.0, and the order is expected.

from react.

SamarthBagga avatar SamarthBagga commented on October 3, 2023

Hi @lili21 , i am new to open source could i get a chance to work on this issue?

from react.

gaearon avatar gaearon commented on October 3, 2023

When you say "messed up" do you mean some tags or missing? Or can you be more specific?

from react.

lili21 avatar lili21 commented on October 3, 2023

the order of links is not expected.

from react.

lili21 avatar lili21 commented on October 3, 2023

those <link rel=modulepreload /> tags have been moved into head, which should be in body.

from react.

lili21 avatar lili21 commented on October 3, 2023

it's hurting our performance. you can check the similar problem with vitejs/vite#5120.

after upgrade to react@canary version, we see the same effect in production, the FCP increase about 1s. because all the <link rel=modulepreload /> have been moved into head.

from react.

rossipedia avatar rossipedia commented on October 3, 2023

@gaearon <link rel="modulepreload" /> tags are being moved to before <link rel="stylesheet" /> tags. Since stylesheets are blocking, if you have a decent amount of modulepreloads then you end up delaying the initial render by however long it takes the browser to free up a network connection to fetch the stylesheet due to all the in-flight preloads.

I think modulepreloads should ideally be moved to after the last stylesheet link tag, which would let the browser fetch the blocking CSS as fast as possible before attempting to preload any JS modules, which can occur asynchronously and won't block the initial paint.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.