GithubHelp home page GithubHelp logo

Comments (7)

gnoff avatar gnoff commented on April 19, 2024 1

@ingmarh thanks for reporting. yes we should be using the nonce on the preload if it was present on the underlying script.

@liuyenwei if you want to take a pass at putting together a PR that's be great. I'll review. If you don't think you will be able to provide one this week I'll take care of it soon. let me know if you intend to (no pressure either way)

from react.

gaearon avatar gaearon commented on April 19, 2024

cc @gnoff

from react.

liuyenwei avatar liuyenwei commented on April 19, 2024

I was testing 18.3.0-canary-a389046a5-20230512 and also ran into this same issue.

Just to add onto the use case in the initial post - this also happens for preload links which are generated for React.lazy components.

I'm happy to take a pass at pushing up a PR for this if there is no disagreement that this should be the expected behavior.

from react.

liuyenwei avatar liuyenwei commented on April 19, 2024

@gnoff sounds good - I can work on that this week 👍

from react.

liuyenwei avatar liuyenwei commented on April 19, 2024

@ingmarh @gnoff #26826

from react.

gaearon avatar gaearon commented on April 19, 2024

Closing per #26826 (review).

from react.

ingmarh avatar ingmarh commented on April 19, 2024

I can confirm that the issue is fixed with the latest canary, 18.3.0-canary-535c038d1-20230522.
Thank you for the fix, @liuyenwei.

@gnoff Thanks for your additional comment #26826 (review). It makes a lot of sense to me.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.