GithubHelp home page GithubHelp logo

Comments (5)

sophiebits avatar sophiebits commented on May 3, 2024

we want that the initial loading state to be visible without depending on React's JS to patch things up

Just to be clear, you're looking to avoid the couple lines of JS in the streaming runtime (https://github.com/facebook/react/blob/9617d39eca1fbac58afe73a23580d781ea20211d/packages/react-dom-bindings/src/server/fizz-instruction-set/ReactDOMFizzInstructionSetInlineCodeStrings.js)?

Curious – is there an actual reason this matters for you in practice or just that it feels unclean?

from react.

yepitschunked avatar yepitschunked commented on May 3, 2024

Yeah, we'd just rather not have a completely blank page when JS is disabled.

from react.

sophiebits avatar sophiebits commented on May 3, 2024

@sebmarkbage Thoughts on if it makes sense to have a way to start rendering the shell immediately but block when encountering the first Suspense boundary?

from react.

sebmarkbage avatar sebmarkbage commented on May 3, 2024

I don’t get. Why not just remove the Suspense boundary?

from react.

yepitschunked avatar yepitschunked commented on May 3, 2024

I think the React assumption is that the app shell doesn't depend on any network requests, or that you can wait for them before calling renderToPipeableStream.

We want to early flush style/link tags in our <head> ASAP; we can do this immediately since it's baked into the build from the bundler. We also have a skeleton loading state that depends on some network queries.

So we can either:

  1. renderToPipeableStream immediately to early flush, and wrap the skeleton in Suspense, which means the page is blank without Javascript
  2. Await the network queries first to avoid the Suspense boundary, which gets the skeleton displayed without Javascript, but will delay early flush

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.