Bug: missing button data in form when submitted via `formAction` about react

[mattcarrollcode]

Standard HTML forms provide the name and value of the button that submitted the form even if the button is outside the form tag: https://codesandbox.io/p/sandbox/practical-smoke-h6s2wp?file=%2Fapp.js%3A11%2C24

[SiddiqAM1]

import React, { useRef } from "react";

const Component = () => {
const submitButtonRef = useRef(null);

function action(formData) {
console.log(formData.get("n1"));
}

function handleSubmit(event) {
event.preventDefault();
submitButtonRef.current.click();
}

return (
<>

Submit

</>
);
};

export default Component;

[SiddiqAM1]

Use a hidden submit button inside of the form tag and programmatically click it when the external button is clicked.

[SiddiqAM1]

you can also use React Hook Form Library

[mattcarrollcode]

This also seems to be a problem when using formAction on a button inside the form. If you have a button that has the formAction attribute the name and value of that button are not surfaced in the form data reguardless of whether the button is inside the form or outside the form.

Code example comparing a "default" submit button (which does surface the button's form data properly) and a button with the formAction attribute set with a client action handler: https://codesandbox.io/s/hungry-bose-j6tv7p?file=/App.js

[sophiebits]

Code pointer for debugging – it's meant to be added here:

react/packages/react-dom-bindings/src/events/plugins/FormActionEventPlugin.js

Lines 83 to 97 in e3748a0

	if (submitter) {
	// The submitter's value should be included in the FormData.
	// It should be in the document order in the form.
	// Since the FormData constructor invokes the formdata event it also
	// needs to be available before that happens so after construction it's too
	// late. We use a temporary fake node for the duration of this event.
	// TODO: FormData takes a second argument that it's the submitter but this
	// is fairly new so not all browsers support it yet. Switch to that technique
	// when available.
	const temp = submitter.ownerDocument.createElement('input');
	temp.name = submitter.name;
	temp.value = submitter.value;
	(submitter.parentNode: any).insertBefore(temp, submitter);
	formData = new FormData(form);
	(temp.parentNode: any).removeChild(temp);

[AlejandroBlanco2001]

@mattcarrollcode I have faced this similar issue when building forms with the button outside the <form> tag and using the attribute form inside the button with React. I think that in your example works because is pure HTML, but as for as I understand this situations is due on how React handles this event, to overcome this I always use onSubmit event.

Maybe have a deeper look on the code pointed by @sophiebits would give more clarity.

[lllomh]

This is an auto-reply email.Hi, due to the high volume of emails, I will get back to you as soon as possible within three days.

[jupapios]

I just created a PR that should fix the original issue, @mattcarrollcode regarding the second issue, it seems there is a test that expects such behavior, so I guess that, for now, it is expected, but I might be wrong, @sophiebits can you confirm, please? 🙏

[lllomh]

This is an auto-reply email.Hi, due to the high volume of emails, I will get back to you as soon as possible within three days.

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!