Comments (8)
This is only a bug when used with
Activity
or does it also happen when a suspended tree unsuspends?
The scope of the bug I've reported here requires Offscreen/Activity.
I'm still trying to write a test for it so that we can pick it up again at a later stage.
@eps1lon I already wrote a test for this in PR #27676
from react.
If it would be useful, I can create a failing unit test from my Code Sandbox. (Edit: #27676)
I'd also be happy to submit a PR with a proposed fix (but I'm less familiar with this hook's code in particular, so I might not be the best person to do this.)
Either way, let me know if the above would be helpful.
from react.
If I’m not mistaken, this line is meant to catch if the store was mutated in between render and subscribe (if we were not already subscribed to the store at render time):
Perhaps this code isn’t running at the right time when reviving the tree.
from react.
Agreed. I think that code only runs during mount or if the getSnapshot
function identity has changed. (In this case it doesn’t get run because the hidden to visible transition is an update and getSnapshot
is a stable function reference. I tried to mention that in the Loom, but maybe I wasn't very clear.)
from react.
@acdlite are we missing a mutated value check here?
from react.
Friendly ping.
from react.
This is only a bug when used with Activity
or does it also happen when a suspended tree unsuspends?
If it's just with Activity
it may take a while to fix it since it's currently being deprioritized: https://react.dev/blog/2024/02/15/react-labs-what-we-have-been-working-on-february-2024#offscreen-renamed-to-activity
I'm still trying to write a test for it so that we can pick it up again at a later stage.
from react.
You can also repro this when you remove the store.set
from the parent and move it into a passive effect before the useSyncExternalStore
call:
function App({mode, revision}) {
return (
<React.unstable_Activity mode={mode}>
<Subscriber revision={revision} />
</React.unstable_Activity>
);
}
function Subscriber({revision: propRevision}) {
React.useEffect(() => {
console.log('store.set');
store.set('revision:' + propRevision);
}, [propRevision]);
const revision = useSyncExternalStore(store.subscribe, store.getState);
return <Text text={revision} />;
}
If that passive effect is moved after the useSyncExternalStore
, it passes again because then React will have subscribed to store changes before the passive effect runs
-React.useEffect(() => {
- console.log('store.set');
- store.set('revision:' + propRevision);
-}, [propRevision]);
const revision = useSyncExternalStore(store.subscribe, store.getState);
+React.useEffect(() => {
+ console.log('store.set');
+ store.set('revision:' + propRevision);
+}, [propRevision]);
from react.
Related Issues (20)
- Bug: Hydration error due to <button> HOT 6
- Bug: Search functionality not working correctly on react.dev in Safari on iOS real device (iPhone 12 Pro) HOT 2
- Bug:
- Google Translate causing "Text content does not match server-rendered HTML" HOT 1
- Bug: useFormState formAction becomes null in strict mode HOT 1
- Bug: Source is not showing in 5.0.2 HOT 9
- Question and suggest: The official identifier of Server Compnoent and Client Component HOT 3
- Bug: when installing the application, the old version of "react-scripts" is installed HOT 1
- Bug: Uncaught DOMException: Failed to set the 'value' property on 'HTMLInputElement': This input element accepts a filename, which may only be programmatically set to the empty string. HOT 4
- Bug: optimistic state (useOptimistic) shows both optimistic and returned from server data when running several async actions HOT 6
- [DevTools Bug]: React Profiler reports higher hook numbers than shown in Components HOT 2
- about the react performance (how to improve it) HOT 3
- Bug: use() hook HOT 4
- Bug: Flight (RSC) examples are not accessible HOT 1
- useMemo reruns when the dependencies not changed when memoised value is a fn HOT 3
- Bug: [Flight] Async server components in `ai/rsc` not rendered correctly HOT 1
- Bug: React Dev tools extension showing wrong source file path on inspection HOT 4
- Bug: Using the hook useDeferredValue - Suspense fallback didn't show the contents HOT 4
- Bug: react-intl formatMessage cannot format message with param that neat by Single quotation mark HOT 3
- custom use directives + using closure serializer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.