GithubHelp home page GithubHelp logo

Comments (2)

ritikbanger avatar ritikbanger commented on July 17, 2024

The proposal looks fine but their are certain things here:

  1. Introducing a universal solution for component overrides might make the codebase harder to maintain in the long run. Developers might need to spend extra time understanding and debugging the context-based overrides, especially if the application grows in complexity.

  2. The proposed solution allows for the override of any component, which might lead to unexpected behavior. It breaks the usual contract between components and their consumers, potentially causing issues when different parts of the application rely on consistent component behavior.

React already provides mechanisms for component customization, such as props and higher-order components. These established patterns might be more familiar to developers and could be preferred over introducing a new context-based approach.

let me know your thoughts.

CC @rickhanlonii

from react.

rickhanlonii avatar rickhanlonii commented on July 17, 2024

It's clever, but dependency injection would violate the declarative principles of React since anything anywhere could override anything. If you need to provide a component to a library, that library should provide a prop, and if they dont then you can fork the library.

Closing as won't do, but thanks for the suggestion.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.