GithubHelp home page GithubHelp logo

Comments (3)

billyjanitsch avatar billyjanitsch commented on May 3, 2024 2

This is by design. fetcher.submit(...) passes fetcher to the method call as this, so the rule is correct to require fetcher as a dependency. You can destructure to get a function that can be used as a dependency:

const fetcher = useFetcher();
const {submit} = fetcher
const onClick = useCallback(() => submit(XXX), [submit]);

See #16265, as well as #20755 for a proposal to make this configurable.

from react.

julianhille avatar julianhille commented on May 3, 2024 1

whoever reaches here:
do not use fetcher as a dependecy the fetcher object is not stable and if you do something like


const fetcher = useFetcher();

useEffect(() => {...}, [fetcher])

that will cause the useEffect to be called everytime as fetcher changes everytime.

from react.

julienw avatar julienw commented on May 3, 2024

Ah interesting ! Yes I see the point.
Indeed I didn't want to do what you suggest because I wasn't sure if a proper this was needed... but failed to make the connection ๐Ÿ˜‚

I'm closing the issue then. Hopefully this could help other folks though.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.