Comments (9)
hmmm, it's set to public for me 🤔
I'll just paste the (rather simple) setup code for reference, hopefully setting it to private and public again will have solved the issue though.
export default function App() {
const [count, setCount] = React.useState(0);
const ref = React.useRef<HTMLDivElement>(null);
React.useEffect(() => {
if (ref.current == null) {
return;
}
ref.current.innerHTML = ref.current.innerHTML; // enable this and react "breaks"
}, []);
return (
<div>
<button onClick={() => setCount(count + 1)}>Inc</button>
{count}
<div ref={ref}>
<div>{count}</div>
</div>
</div>
);
}
from react.
@hesxenon The provided sandbox seems to be private or does not exist at all, please recheck.
from react.
React uses a virtual DOM
to track changes and updates only the parts of the actual DOM
that have changed. When you directly set innerHTML
, it bypasses React’s control, causing inconsistencies.
Setting innerHTML replaces the entire contents of the element, and React loses track of what it should update during subsequent renders.
To avoid this issue, you should let React handle the updates. If you need to perform some DOM
manipulation, do it in a way that doesn’t interfere with React’s reconciliation process.
Remove the line ref.current.innerHTML = ref.current.innerHTML;
and let React handle the updates. If you need to manipulate the DOM
, consider other approaches that don’t conflict with React’s rendering.
import React from "react";
import "./styles.css";
export default function App() {
const [count, setCount] = React.useState(0);
const ref = React.useRef<HTMLDivElement>(null);
React.useEffect(() => {
if (ref.current) {
// Perform any necessary DOM manipulation here without setting innerHTML directly
}
}, [count]); // Run effect only when count changes
return (
<div>
<button onClick={() => setCount(count + 1)}>Inc</button>
{count}
<div ref={ref}>
<div>{count}</div>
</div>
</div>
);
}
from react.
I can understand why this is happening but it's easy to say "do it in a way that doesn't conflict with react" without considering that e.g. webcomponents are not (and should not) be geared towards react and might include functionality that conflicts with react in a way that isn't possible to control.
In short: I hope react doesn't become like angular - drifting away from standards and simply stating to "do it the way". (and this is starting to feel like the "niceties" encountered when using primeNG and angular/mui)
If you're saying that react won't support such cases feel free to close this a not planned, I could absolutely understand that. I just hope you won't.
from react.
@eps1lon please check this case
from react.
I can understand why this is happening but it's easy to say "do it in a way that doesn't conflict with react" without considering that e.g. webcomponents are not (and should not) be geared towards react and might include functionality that conflicts with react in a way that isn't possible to control.
Could you provide an example with Web Components then? It's not clear from the issue why React breaks Web Components here.
from react.
sure thing, here you go: codesandbox that is set to public and I just tested it in a private window. Basically this just uses a web component that resets its innerHTML on closest form reset.
I think it's a reasonable case for webcomponents to reset to some state (that might not be retrievable from its attributes!) when the closest form resets while not using the shadow dom (don't know if that makes a difference here).
from react.
I don't think this is possible. When React re-renders, how would it know how to reconcile the new children against what the Web component set via this.innerHTML =
?
from react.
from react.
Related Issues (20)
- Bug: Wrong detection of non-boolean attribute when working with React API HOT 2
- Cannot find name 'dialog' HOT 2
- Bug: useMemo has a problem of executing multiple times without changing dependencies HOT 2
- Bug: bug de teste
- [React 19] Export SuspenseException HOT 2
- [React 19] [bug] SVG with dangerouslySetInnerHTML content does not trigger first click HOT 8
- [React 19] - `ReactElement` created from `React.createElement` are not renderable anymore HOT 3
- [Compiler Bug]: function parameter inside component override outer parameter incorrectly
- forceUpdate not work in child component GuardGraph
- [React 19] useOptimistic is not updating its optimistic collection immediately HOT 6
- Bug: useEffect and Event Handler Timing Regressions in React 18 Legacy Mode HOT 1
- [DevTools Bug]: No way to debug suspense events
- [Compiler Bug]: setState in useEffect / react compiler and eslint hooks plugin HOT 1
- [DevTools Bug] Cannot add node "20468" because a node with that id is already in the Store. HOT 1
- [Help Wanted] How can I become a member of reactjs? HOT 1
- [React 19]useEffect cleaned the wrong state in StrictMode HOT 7
- Inability to prioritise hydration & react yields too willingly HOT 2
- [DevTools Bug]: Script tag connection method not working in 6.0.0 HOT 1
- Bug: DevTools 6.0.0 element inspector not working with React Native 0.75 HOT 1
- Bug: re-rendering order of onBlur and onClick inconsistent between desktop and mobile browsers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.